Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v12 05/17] s390/vfio-ap: manage link between queue struct
 and matrix mdev
To:     Halil Pasic <pasic@linux.ibm.com>
Cc:     linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org, freude@linux.ibm.com, borntraeger@de.ibm.com,
        cohuck@redhat.com, mjrosato@linux.ibm.com,
        alex.williamson@redhat.com, kwankhede@nvidia.com,
        fiuczy@linux.ibm.com, frankja@linux.ibm.com, david@redhat.com,
        hca@linux.ibm.com, gor@linux.ibm.com
References: <20201124214016.3013-1-akrowiak@linux.ibm.com>
 <20201124214016.3013-6-akrowiak@linux.ibm.com>
 <20201126150828.78776e62.pasic@linux.ibm.com>
From:   Tony Krowiak <akrowiak@linux.ibm.com>
Message-ID: <eac90113-4c68-a42f-cbfa-41e6b2780380@linux.ibm.com>
Date:   Mon, 14 Dec 2020 18:37:08 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <20201126150828.78776e62.pasic@linux.ibm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 11/26/20 9:08 AM, Halil Pasic wrote:
> On Tue, 24 Nov 2020 16:40:04 -0500
> Tony Krowiak <akrowiak@linux.ibm.com> wrote:
>
>> @@ -1155,6 +1243,11 @@ static int vfio_ap_mdev_reset_queues(struct mdev_device *mdev)
>>   			     matrix_mdev->matrix.apm_max + 1) {
>>   		for_each_set_bit_inv(apqi, matrix_mdev->matrix.aqm,
>>   				     matrix_mdev->matrix.aqm_max + 1) {
>> +			q = vfio_ap_mdev_get_queue(matrix_mdev,
>> +						   AP_MKQID(apid, apqi));
>> +			if (!q)
>> +				continue;
>> +
>>   			ret = vfio_ap_mdev_reset_queue(apid, apqi, 1);
>>   			/*
>>   			 * Regardless whether a queue turns out to be busy, or
>> @@ -1164,9 +1257,7 @@ static int vfio_ap_mdev_reset_queues(struct mdev_device *mdev)
>>   			if (ret)
>>   				rc = ret;
>>   
>> -			q = vfio_ap_get_queue(matrix_mdev, AP_MKQID(apid, apqi);
>> -			if (q)
>> -				vfio_ap_free_aqic_resources(q);
>> +			vfio_ap_free_aqic_resources(q);
>>   		}
>>   	}
> During the review of v11 we discussed this. Introducing this the one
> way around, just to change it in the next patch, which should deal
> with something different makes no sense to me.

This is handled by the vfio_ap_mdev_reset_queue() function in the
next version.

>
> BTW I've provided a ton of feedback for '[PATCH v11 03/14]
> s390/vfio-ap: manage link between queue struct and matrix mdev', but I
> can't find your response to that. Some of the things resurface here, and
> I don't feel like repeating myself. Can you provide me an answer to
> the v11 version?

I can.