Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 3Ef9NWsCimbXCOb9mnDdS8T3kH6ajS4+1nWRkFxrAfpa9tt11pHCvqdYTA1vii6ZBsekpbsD1G
 t5+3l5w3JpgR6NpjY6fMLF2rcQjHQV9DmggOZmfkQcHmRhkcrlSqaH87mnZqAOp6pSAa/IhKgN
 WrkIrwh2uxAXirEDaM8SAUbH/c+rGd3mcSnA8O9m4YDbMHoEGHLHOSSqDFRMFJofxgSD/9ZWe9
 +OJmX29rhbIvwx0U1wbYhJLNaMRZ2rMsqrRzahd5Ny0zpkEtRV+HUE2Bsb57g50VQTmXfeo7K0
 3CI=
From:   Damien Le Moal <Damien.LeMoal@wdc.com>
To:     Puranjay Mohan <puranjay12@gmail.com>,
        "bjorn@helgaas.com" <bjorn@helgaas.com>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] drivers: block: skd: remove skd_pci_info()
Thread-Topic: [PATCH v1] drivers: block: skd: remove skd_pci_info()
Thread-Index: AQHW0i2wqDaNil4lgECF1jii2YcNxg==
Date:   Mon, 14 Dec 2020 23:41:40 +0000
Message-ID: <CH2PR04MB6522E0FCC3673C97064156C7E7C70@CH2PR04MB6522.namprd04.prod.outlook.com>
References: <20201214152720.11922-1-puranjay12@gmail.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: e4d8e6ff-e2c7-4e29-7a09-08d8a089ce8a
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2020 23:41:40.8244
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Rnl1CaQ9yY6qi4hVgtNL5VKooJ8VLz4LSEdq2SQX3skGykTtOFer61W8MYPgvNPMaGnUHQNHxFXXyMI5TncruQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR04MB6760
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2020/12/15 0:27, Puranjay Mohan wrote:=0A=
> Change the call to skd_pci_info() to pcie_print_link_status().=0A=
> pcie_print_link_status() can be used to print the link speed and=0A=
> the link width, skd_pci_info() does the same and hence it is removed.=0A=
> =0A=
> Signed-off-by: Puranjay Mohan <puranjay12@gmail.com>=0A=
> ---=0A=
> v1 - Add call to pcie_print_link_status()=0A=
> ---=0A=
>  drivers/block/skd_main.c | 33 +--------------------------------=0A=
>  1 file changed, 1 insertion(+), 32 deletions(-)=0A=
> =0A=
> diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c=0A=
> index a962b4551bed..efd69f349043 100644=0A=
> --- a/drivers/block/skd_main.c=0A=
> +++ b/drivers/block/skd_main.c=0A=
> @@ -3134,40 +3134,10 @@ static const struct pci_device_id skd_pci_tbl[] =
=3D {=0A=
>  =0A=
>  MODULE_DEVICE_TABLE(pci, skd_pci_tbl);=0A=
>  =0A=
> -static char *skd_pci_info(struct skd_device *skdev, char *str)=0A=
> -{=0A=
> -	int pcie_reg;=0A=
> -=0A=
> -	strcpy(str, "PCIe (");=0A=
> -	pcie_reg =3D pci_find_capability(skdev->pdev, PCI_CAP_ID_EXP);=0A=
> -=0A=
> -	if (pcie_reg) {=0A=
> -=0A=
> -		char lwstr[6];=0A=
> -		uint16_t pcie_lstat, lspeed, lwidth;=0A=
> -=0A=
> -		pcie_reg +=3D 0x12;=0A=
> -		pci_read_config_word(skdev->pdev, pcie_reg, &pcie_lstat);=0A=
> -		lspeed =3D pcie_lstat & (0xF);=0A=
> -		lwidth =3D (pcie_lstat & 0x3F0) >> 4;=0A=
> -=0A=
> -		if (lspeed =3D=3D 1)=0A=
> -			strcat(str, "2.5GT/s ");=0A=
> -		else if (lspeed =3D=3D 2)=0A=
> -			strcat(str, "5.0GT/s ");=0A=
> -		else=0A=
> -			strcat(str, "<unknown> ");=0A=
> -		snprintf(lwstr, sizeof(lwstr), "%dX)", lwidth);=0A=
> -		strcat(str, lwstr);=0A=
> -	}=0A=
> -	return str;=0A=
> -}=0A=
> -=0A=
>  static int skd_pci_probe(struct pci_dev *pdev, const struct pci_device_i=
d *ent)=0A=
>  {=0A=
>  	int i;=0A=
>  	int rc =3D 0;=0A=
> -	char pci_str[32];=0A=
>  	struct skd_device *skdev;=0A=
>  =0A=
>  	dev_dbg(&pdev->dev, "vendor=3D%04X device=3D%04x\n", pdev->vendor,=0A=
> @@ -3201,8 +3171,7 @@ static int skd_pci_probe(struct pci_dev *pdev, cons=
t struct pci_device_id *ent)=0A=
>  		goto err_out_regions;=0A=
>  	}=0A=
>  =0A=
> -	skd_pci_info(skdev, pci_str);=0A=
> -	dev_info(&pdev->dev, "%s 64bit\n", pci_str);=0A=
> +	pcie_print_link_status(pdev);=0A=
>  =0A=
>  	pci_set_master(pdev);=0A=
>  	rc =3D pci_enable_pcie_error_reporting(pdev);=0A=
> =0A=
=0A=
Note: V1 of this patch was the one I commented on. This one should thus be =
V2.=0A=
=0A=
In any case, this looks OK to me.=0A=
=0A=
Acked-by: Damien Le Moal <damien.lemoal@wdc.com>=0A=
=0A=
=0A=
-- =0A=
Damien Le Moal=0A=
Western Digital Research=0A=