Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2974668pxu; Mon, 14 Dec 2020 16:35:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJydQdVsGmPtoyTKdkz8CEUQu/vkC34WedXTViAG2M5n9gC2ET95zne6gtAT20avZSxHB8Io X-Received: by 2002:a50:e791:: with SMTP id b17mr26994521edn.388.1607992503996; Mon, 14 Dec 2020 16:35:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607992503; cv=none; d=google.com; s=arc-20160816; b=iyGf7nXEh49VR5HkCGl+9RjPI8q8SLBgQM7uCUsdILAsV72MGB7FQD4eRIaVQttZPq b8swzmHoWyTJomTKniMu66XneuEjFWWMAiGvZqDDgHlupCGPEcNo/4aChlNTu03ByVW/ M0x6MVwZSZd0JXQXLsqh62YumBhz21gMbVSZtQIV2DPJjFs0G00NRsT/ulflsW0zsU4S 0THFLPLqgb8PHhWBVpd/0ntQOuMDjXzn1tkn2zw+ArdF5Z+rtITMswYaIx3U2ebGjAHz uDPlOk4oHHBwGuluD8BpZVWyJwwLNr9UjHsIiJrrLN8GxIck9g669fAmfRVElWXLV8L7 vJ3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=vucjdQCLyAd3Q0AdZs6xHlknqACs9Tp5nQldv2CB1TU=; b=WDSwyxf6jQrUwhlqJ9UsC0DcFfUy8vr7UoGs7sw577VtfLPIa4atA/m72YBsRmDqb0 IjMtcDLcK43OM/gDfzByEGelQZzv7vUEXHzAs0SY23Twc4nadcEQxnoiQLlCjm0rir1P Nrx7OYIeFoAzuH0ZJJQ9Uv04Y23LLMUhEku5bs9PMXLRKFEYS+dI/+Lmxf0PvD2CvTSi Uly8b+f00+4kYnvSQgi14Yvmur2R+uMPenwjaL4C04j0MfKYbeGJaRk2qgScEMRi7Lkr 5LXqWOqwLT8KMqPflhe2+l3cCejWGSSxRXbIsVa95VD8yKGntiX3QeF8QFW6iAFqH4pQ jCOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=qIr4fpcC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b18si62773eja.285.2020.12.14.16.34.40; Mon, 14 Dec 2020 16:35:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=qIr4fpcC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728603AbgLNXuV (ORCPT + 99 others); Mon, 14 Dec 2020 18:50:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725968AbgLNXuT (ORCPT ); Mon, 14 Dec 2020 18:50:19 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF37BC06179C; Mon, 14 Dec 2020 15:49:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=vucjdQCLyAd3Q0AdZs6xHlknqACs9Tp5nQldv2CB1TU=; b=qIr4fpcCqB3zbFi3ySlzcZp0ZX vD0DiVNJsS3n6o6Xl4V+jBmK1kPukdAjKZN62wYsz98OY2WGnDVcAeGcTgb8GIP9LAPhuOfG+I16J YEnhGQjNWYf3UdkPzpdF5TbDMJPcHkGPxXArzYo/Qugm/RTSAqpBbZtiQbUHt7s0NlHae7qYBlVi3 CGzdUhoR6HmBuale0d4+F/kxOGff1i3/I4xwP14uo9EUke4r6564WhGx5t8pXvj0RGcpnphNVEaU+ WgdsfmFMolAR5Qk3paKUBOX6n65O8ZyXsXrA8i5BDGQeHGrivK5/NHwqH8HAMGepLSwG8KU+XtyNv iO8kOqlA==; Received: from [2601:1c0:6280:3f0::1494] by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1koxay-0008LS-K6; Mon, 14 Dec 2020 23:49:36 +0000 Subject: Re: [PATCH -next] platform: surface: fix non-PM_SLEEP build warnings To: Andy Shevchenko , Arnd Bergmann Cc: Linux Kernel Mailing List , Maximilian Luz , Hans de Goede , Platform Driver References: <20201211190335.16501-1-rdunlap@infradead.org> <3d5a5c8f-4bb1-6205-ae76-354473d59a18@infradead.org> From: Randy Dunlap Message-ID: <0f07d6b8-6a28-ba31-9cfa-53abffb0c0ff@infradead.org> Date: Mon, 14 Dec 2020 15:49:33 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/14/20 3:19 AM, Andy Shevchenko wrote: > On Mon, Dec 14, 2020 at 2:53 AM Randy Dunlap wrote: >> On 12/12/20 11:07 AM, Andy Shevchenko wrote: >>> On Sat, Dec 12, 2020 at 7:05 PM Randy Dunlap wrote: > > ... > >>> Here [1] is the rationale behind annotation vs. ifdeffery. >>> >>> [1]: https://lore.kernel.org/patchwork/patch/732981/ >>> >> Thanks for the link. I'll send a v2. >> >> Could we add that to the Linux BKP (Best Known Practices) >> document? > > Perhaps. The author of that is Arnd, maybe he has something to add. > Where is it located? My search foo could not find it. thanks. -- ~Randy