Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v1] serial: 8250_fintek: Print Fintek chip name
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Flavio Suligoi <f.suligoi@asem.it>
Cc:     Jiri Slaby <jirislaby@kernel.org>,
        "Gustavo A . R . Silva" <gustavoars@kernel.org>,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20201214131445.954822-1-f.suligoi@asem.it>
 <X9dr2IvOgPyhsalE@kroah.com>
From:   "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
Message-ID: <1b5f557d-165b-d2be-2c61-ef133019edf7@gmail.com>
Date:   Tue, 15 Dec 2020 08:29:41 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.1
MIME-Version: 1.0
In-Reply-To: <X9dr2IvOgPyhsalE@kroah.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

Greg Kroah-Hartman 於 2020/12/14 下午 09:42 寫道:
>>   	pdata->pid = chip;
>> +
>> +	pr_info("%s%s%s Fintek %s\n",
>> +		uart->port.dev ? dev_name(uart->port.dev) : "",
>> +		uart->port.dev ? ": " : "",
>> +		uart->port.name,
>> +		chip_name);
> 
> Drivers, if all goes well, should not print anything to the kernel log.
> This isn't ok.
> 
> And even if it was, dev_info() would be the correct thing to do...

Maybe can transform pr_info() to dev_dbg() for debug usage ?

-- 
With Best Regards,
Peter Hong