Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] fuse: clean up redundant assignment
From:   Ruan Shiyang <ruansy.fnst@cn.fujitsu.com>
To:     <miklos@szeredi.hu>, <linux-fsdevel@vger.kernel.org>
CC:     <linux-kernel@vger.kernel.org>
References: <20201126040313.141513-1-ruansy.fnst@cn.fujitsu.com>
Message-ID: <53733a62-c04c-48b4-af0c-e8bcaeca948b@cn.fujitsu.com>
Date:   Mon, 14 Dec 2020 13:43:26 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.1
MIME-Version: 1.0
In-Reply-To: <20201126040313.141513-1-ruansy.fnst@cn.fujitsu.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi guys,

any ideas?


--
Thanks,
Ruan Shiyang.

On 2020/11/26 下午12:03, Shiyang Ruan wrote:
> The 'err' was assigned to -ENOMEM in just few lines above, no need to be
> assigned again.
> 
> Signed-off-by: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>
> ---
>   fs/fuse/dir.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
> index ff7dbeb16f88..f28eb54517ff 100644
> --- a/fs/fuse/dir.c
> +++ b/fs/fuse/dir.c
> @@ -528,7 +528,6 @@ static int fuse_create_open(struct inode *dir, struct dentry *entry,
>   	if (!forget)
>   		goto out_err;
>   
> -	err = -ENOMEM;
>   	ff = fuse_file_alloc(fm);
>   	if (!ff)
>   		goto out_put_forget_req;
>