Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp3024720pxu; Mon, 14 Dec 2020 18:20:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJzef81OgeYyrhAuEtub1jnmLqKUrc2ZDXOMpJBdT5qicxIiNA4k0xhe6/wJkQBGFx/CdGnD X-Received: by 2002:a05:6402:687:: with SMTP id f7mr27302764edy.314.1607998802004; Mon, 14 Dec 2020 18:20:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607998801; cv=none; d=google.com; s=arc-20160816; b=u4skziA3XE0txqDoLspuxqJFnE7lziRG197kn81Fzx7oXBzVpzVBGlqG0VG1hn1vOv GvBREncMx44YAJlVBbVRpD8F1Guj0cRwczkyhEIF9usLOeeX+1Yqz3NKCdjMMs5bXXkP 55hgw8W97v2r6lywT8hmrr4ws1T52QFp5u6H6qtPJCicscHt1rur/vEfY7mQQxb0//+d ghMMzriJdWw91jBOiVzSHj/07ybdxOm4a+pYo7yIpeHKzBaJe+A1pQMFpkgogEPXCm+W Io4OI8ITHfPcVdVoSb5vKc4oKNRQQpUIQ5vcNmT5XBv3wSUNWuqhNHTtHuk8bb9NC12N GG0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=Q0MRhiWRLJK1W46jtq0ybvcIfpUEJUvzEaRuk715Glg=; b=ScKPBu3ms60LxZGbUxAHmlW55BEoBcKiarly/hOABuzkWEz8w3D17FDg71P+bcpK9J VDJLih/VxF6DykpILZJ9drr0LI4tqe6cstQ8daIE/z+b7bCbUKR+3RI+QZaP2WxdcTwm awWGFmjysAn2Kl0PrvOZOko7ZXK4LOSajcKmd9uJGkDb766hxhIWFJ0ZHgQir9RKP1Vu Mnj6jBHQjcCHi8glCPQzgv9RU4A4DR/vNl3Ey4HlTimMVWz9wNZK3x/KGfYBSDVV5Obr 0s+0dWw8ylv24w/Iy9MkK46xMhNiGQz10Hy+3bcAohYc7iuZMzC9mJIlbefYdhJKLOn6 Xp8Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c23si127457edt.456.2020.12.14.18.19.39; Mon, 14 Dec 2020 18:20:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726410AbgLOBLC (ORCPT + 99 others); Mon, 14 Dec 2020 20:11:02 -0500 Received: from mail109.syd.optusnet.com.au ([211.29.132.80]:47128 "EHLO mail109.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728471AbgLOBKq (ORCPT ); Mon, 14 Dec 2020 20:10:46 -0500 Received: from dread.disaster.area (pa49-179-6-140.pa.nsw.optusnet.com.au [49.179.6.140]) by mail109.syd.optusnet.com.au (Postfix) with ESMTPS id 4B05B86E83; Tue, 15 Dec 2020 12:09:48 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1koyqZ-0043Jc-Pu; Tue, 15 Dec 2020 12:09:47 +1100 Date: Tue, 15 Dec 2020 12:09:47 +1100 From: Dave Chinner To: Pavel Begunkov Cc: linux-block@vger.kernel.org, Jens Axboe , Christoph Hellwig , Matthew Wilcox , Ming Lei , Johannes Weiner , Alexander Viro , "Darrick J . Wong" , "Martin K . Petersen" , Jonathan Corbet , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, target-devel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v1 5/6] bio: add a helper calculating nr segments to alloc Message-ID: <20201215010947.GI632069@dread.disaster.area> References: <94b6f76d2d47569742ee47caede1504926f9807a.1607976425.git.asml.silence@gmail.com> <20201215010023.GG632069@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201215010023.GG632069@dread.disaster.area> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=YKPhNiOx c=1 sm=1 tr=0 cx=a_idp_d a=uDU3YIYVKEaHT0eX+MXYOQ==:117 a=uDU3YIYVKEaHT0eX+MXYOQ==:17 a=kj9zAlcOel0A:10 a=zTNgK-yGK50A:10 a=7-415B0cAAAA:8 a=WwzpMGNPEthxJ6wOJHYA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 15, 2020 at 12:00:23PM +1100, Dave Chinner wrote: > On Tue, Dec 15, 2020 at 12:20:24AM +0000, Pavel Begunkov wrote: > > A preparation patch. It adds a simple helper which abstracts out number > > of segments we're allocating for a bio from iov_iter_npages(). > > Preparation for what? bio_iov_vecs_to_alloc() doesn't seem to be > used outside this specific patch, so it's not clear what it's > actually needed for... Never mind, I'm just blind. Cheers, Dave. -- Dave Chinner david@fromorbit.com