Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp3026781pxu; Mon, 14 Dec 2020 18:23:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJzECIFmPqRVTHCnYBi3BC8peEolTD1VSquRiVEXP9z2sKwQ6kCIVnBD0tMwaj0F5Pj9iAJ0 X-Received: by 2002:a50:9a83:: with SMTP id p3mr443447edb.42.1607998997410; Mon, 14 Dec 2020 18:23:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607998997; cv=none; d=google.com; s=arc-20160816; b=0uZYRyIa4nwVaE2qOGng8kNixq58KF4Et/2HBJcMa4skczvg52e3IyWB2nWm1AKRYY uXYq7F3jVYTZj8/ro6Dvy1snzjx2dKRyYpb9R8eZmJV5YO36QZEis0XUDEzUD08BFUVR 4wwop2s0gXcRYFtVKfjyBKWgh9M6sE//7VyXLes/pz1JPZ+YaHGIONRDZpmj/EB7gFkd 3DhFyM+LcypnBSzCOmXD2KOstHlEVPHtp2zfc8FH8yJDcmZyk1yBwHHhMwmzgcvR353A 1R/04Nx2XP+htz6VUeN/RssAfcEoHYzA/PGerLUb6ROWmxfU3UimvbDTXewiLAx7YPlN MqQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=PChAzdtbpi+PB7J87DcIhi+vl5NjETLfLM7SecPuwcY=; b=M196FJfIpbEQDINNeXzTXMg55V3kpLfpGFJ8E7mopDcGOQiOiskDUgVsBB2YZo5HeJ fZ3Vz5Z/B97V71+18IQxNV0CG09s8nSNlHSanoJR7wbu/hlg4rcTcdeV5oq652JfBm+V l4l0UZHdRDFEInXnOPYQtDVv0EBCQhq7HAdknyviSZW8x9Bigatlkt+2BOogiKb0DT/u C/ixKToI7w9JnTZSvaigcXoEQQ2A3xmwXBAbNvoisPBt2RZdi4JED0hUmV7Rnj+B1Ugh e5E5G2S4KZKmJ1Oxh9/mHvhHQqlTQfFyz1oVT9pa38tI6ddyynYh/GZa13aQG1343NxC XIbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HIYY4G0Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w10si137497edv.243.2020.12.14.18.22.54; Mon, 14 Dec 2020 18:23:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HIYY4G0Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730781AbgLOBne (ORCPT + 99 others); Mon, 14 Dec 2020 20:43:34 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:60587 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730363AbgLOBnH (ORCPT ); Mon, 14 Dec 2020 20:43:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607996498; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PChAzdtbpi+PB7J87DcIhi+vl5NjETLfLM7SecPuwcY=; b=HIYY4G0QfQNK2paU2qjqY7ECA3c+OG0FwPcb7+gR9iOTYwWp9hbi6xqW5jGswBD9QL3u5y PVa5LiWBHyF5rpV7X3zbz03LwgYiJImBPnu389TFOGFD5WwYDxyLoKfUvAMewbT39i7N+j gOVEZbSGCGex9hyZTatNPzWzFdgSWL0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-335-VMEMQTasPqiCfO3btqz3Kw-1; Mon, 14 Dec 2020 20:41:34 -0500 X-MC-Unique: VMEMQTasPqiCfO3btqz3Kw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A3829180A086; Tue, 15 Dec 2020 01:41:31 +0000 (UTC) Received: from T590 (ovpn-13-7.pek2.redhat.com [10.72.13.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 29ED213470; Tue, 15 Dec 2020 01:41:18 +0000 (UTC) Date: Tue, 15 Dec 2020 09:41:14 +0800 From: Ming Lei To: Pavel Begunkov Cc: linux-block@vger.kernel.org, Jens Axboe , Christoph Hellwig , Matthew Wilcox , Johannes Weiner , Alexander Viro , "Darrick J . Wong" , "Martin K . Petersen" , Jonathan Corbet , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, target-devel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v1 0/6] no-copy bvec Message-ID: <20201215014114.GA1777020@T590> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 15, 2020 at 12:20:19AM +0000, Pavel Begunkov wrote: > Instead of creating a full copy of iter->bvec into bio in direct I/O, > the patchset makes use of the one provided. It changes semantics and > obliges users of asynchronous kiocb to track bvec lifetime, and [1/6] > converts the only place that doesn't. Just think of one corner case: iov_iter(BVEC) may pass bvec table with zero length bvec, which may not be supported by block layer or driver, so this patchset has to address this case first. Please see 7e24969022cb ("block: allow for_each_bvec to support zero len bvec"). thanks, Ming