Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp3037352pxu; Mon, 14 Dec 2020 18:47:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJy0MTsFwVgVtVjgO9ryhJJJoui3fWzZ62KQKNHuLaoyLZkkfRnrlQnEsfq9MQbP89Fepdm/ X-Received: by 2002:a17:906:b7cc:: with SMTP id fy12mr25106025ejb.44.1608000461100; Mon, 14 Dec 2020 18:47:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608000461; cv=none; d=google.com; s=arc-20160816; b=tjKJMrzEeELE366TStlZFvbUAinqT5L0at2CP5zQOrw/MIlDSeE8vG1lG3TutsGFb1 uhsK1lV6k37XUEKD83QQKJH12WC4qn6EPSa5Z1AncvytjZECj8D+IXLkGO383RL39VTE 8jlOWWVMPhW1jjc9zGc1/rjj42jQD12x4T58cNKaaeczrfzZgfZ9GWFu7H8aB3o2M4LW RsSXBJvzlf65QczBdddafFgH5TwU2jaXP6mI38CTv2H98rzNVvzuPNsZpzVP3jqeIb2I ldyejcOYWnsxdtmd586OS08fpupcr0liCC7DPkIjH18j/pdvQ5/Yu1q2yN9Pa29CZ09a o+PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:dkim-signature :date; bh=+d5SQVg6FlcoDnF3k4sKmX1DAJQAd1UdKCqjFlDzJAQ=; b=XOwTqGdOQ56VgfOtsavWVvpBsmDX8DHzGODTH7VliRpJ2Owqi1tuaXSkRv/wfr/gzn COY/KgM2jRYdH+vW7Dyh+VulKp0xqDc8Pa+y/V54pbWn8Atdx4nsuXK+0e0kjB8SLsjZ q+DlNOJdZs5WMUIBiPvIKdXco8MPx1fAr9CmDS/B3GZBldgwniXzMqEgpkEDv+xapxBP zArsYy8b9mCLBAl3qjYMMbnUtUTy+yP9qwFEKDci1BdG4j734UF05FYZ+eJ0/dY60ekS MTvtA9S1qJ8b0rDrkmZ2SLM14l+qyVTupgLf5zIL6VfOL9SOcj7slg8qHhdJx3eJbPal nzYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lxlgVKFo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b12si157329edq.488.2020.12.14.18.47.18; Mon, 14 Dec 2020 18:47:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lxlgVKFo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726807AbgLOCRW (ORCPT + 99 others); Mon, 14 Dec 2020 21:17:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:41212 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726551AbgLOCQb (ORCPT ); Mon, 14 Dec 2020 21:16:31 -0500 Date: Mon, 14 Dec 2020 18:15:48 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607998549; bh=x6Jepcwui9w7+y0mUDCKGKpZYi/QMQ3PRhwL9AvtwC0=; h=From:To:Cc:Subject:In-Reply-To:References:From; b=lxlgVKFo3LFGnr+AmngcOXWBUXt4/jMvq+hzDWJ8IcFus4Mnvrk4R66NPA2ZenMFD 46BpNWqDIsQfsAs7VRRjJP6BSqQLVi6x3WwiXZS717fwf5ObfNx3rTR1JD8iuzTu+P f0kYPXqYFfW8GqwzuS+z+B9VwDahcIcFnATpPb+tLuL+VTsK2GulKgLrk371V3BTRz 8/ooZREkN+o3Ni82675TWwlsq3JU6IOMCtffybo28rO4FccImdCFDcZYIScp4j/sIA SioLjB/TXdB62nCHwUcOHzHrx+0X+8s3voPmSSiTjn2IsaVJrcVONJSmZ5JR9MYDMa wrYxVFq6S12NA== From: Jakub Kicinski To: Rasmus Villemoes Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2] net: dsa: mv88e6xxx: don't set non-existing learn2all bit for 6220/6250 Message-ID: <20201214181548.5eaea143@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201210110645.27765-1-rasmus.villemoes@prevas.dk> References: <20201208090109.363-1-rasmus.villemoes@prevas.dk> <20201210110645.27765-1-rasmus.villemoes@prevas.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Dec 2020 12:06:44 +0100 Rasmus Villemoes wrote: > The 6220 and 6250 switches do not have a learn2all bit in global1, ATU > control register; bit 3 is reserverd. > > On the switches that do have that bit, it is used to control whether > learning frames are sent out the ports that have the message_port bit > set. So rather than adding yet another chip method, use the existence > of the ->port_setup_message_port method as a proxy for determining > whether the learn2all bit exists (and should be set). > > Signed-off-by: Rasmus Villemoes Applied.