Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <410bf2a27978abb74ba41bc9f9198dcf85636b3c.camel@gmail.com>
Subject: Re: [PATCH v4 5/6] scsi: ufs: Cleanup WB buffer flush toggle
 implementation
From:   Bean Huo <huobean@gmail.com>
To:     Stanley Chu <stanley.chu@mediatek.com>
Cc:     alim.akhtar@samsung.com, avri.altman@wdc.com,
        asutoshd@codeaurora.org, jejb@linux.ibm.com,
        martin.petersen@oracle.com, beanhuo@micron.com, bvanassche@acm.org,
        tomas.winkler@intel.com, cang@codeaurora.org,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Tue, 15 Dec 2020 10:28:02 +0100
In-Reply-To: <1608023234.10163.19.camel@mtkswgap22>
References: <20201211140035.20016-1-huobean@gmail.com>
         <20201211140035.20016-6-huobean@gmail.com>
         <1608023234.10163.19.camel@mtkswgap22>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 2020-12-15 at 17:07 +0800, Stanley Chu wrote:
> >        if (ret) {
> > -             dev_warn(hba->dev, "%s: WB - buf flush disable failed
> > %d\n",
> > -                      __func__, ret);
> > -     } else {
> > -             hba->dev_info.wb_buf_flush_enabled = false;
> > -             dev_dbg(hba->dev, "WB - Flush disabled: %d\n", ret);
> > +             dev_err(hba->dev, "%s WB-Buf Flush %s failed %d\n",
> > __func__,
> > +                     enable ? "enable" : "disable", ret);
> > +             goto out;
> >        }
> >   
> > +     if (enable)
> > +             hba->dev_info.wb_buf_flush_enabled = true;
> > +     else
> > +             hba->dev_info.wb_buf_flush_enabled = false;
> 
> Perhaps this could be simpler as below?
> 
> hba->dev_info.wb_buf_flush_enabled = enable;

Thanks, will be changed in next version.

Bean