Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <615bb13dc394dac2b56fa60787e1841d2db12462.camel@gmail.com>
Subject: Re: [PATCH v4 3/6] scsi: ufs: Group UFS WB related flags to struct
 ufs_dev_info
From:   Bean Huo <huobean@gmail.com>
To:     Stanley Chu <stanley.chu@mediatek.com>
Cc:     alim.akhtar@samsung.com, avri.altman@wdc.com,
        asutoshd@codeaurora.org, jejb@linux.ibm.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Tue, 15 Dec 2020 10:42:36 +0100
In-Reply-To: <1608022873.10163.17.camel@mtkswgap22>
References: <20201211140035.20016-1-huobean@gmail.com>
         <20201211140035.20016-4-huobean@gmail.com>
         <1608022873.10163.17.camel@mtkswgap22>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 2020-12-15 at 17:01 +0800, Stanley Chu wrote:
> > +     bool    wb_buf_flush_enabled;
> > +     u8      wb_dedicated_lu;
> > +     u8      b_wb_buffer_type;
> > +     u32     d_wb_alloc_units;
> > +
> > +     bool    b_rpm_dev_flush_capable;
> > +     u8      b_presrv_uspc_en;
> 
> Perhaps we could unify the style of these WB related stuff to wb_* ?

yes, agree. I will change them.

> 
> Besides, I am not sure if using tab instead space between the type
> and
> name in this struct is a good idea.
> 
using space, in addition single space, type and parameter names are
mixed. 


use space:

 /* UFS WB related flags */
bool wb_enabled;
bool wb_buf_flush_enabled;
u8
wb_dedicated_lu;
u8 b_wb_buffer_type;
u32 d_wb_alloc_units;

use table:

 /* UFS WB related flags */
bool    wb_enabled;
bool    wb_buf_flush_enabled;
u8      wb_dedicated_lu;
u8      b_wb_buffer_type;
u32     d_wb_alloc_units;

I think, the result is very clear comparing above two examples. yes,
there is no explicit stipulation that we must use space or tab. Both
styles exist in Linux. Maybe this is just matter of personal interest.


Bean

> Thanks,
> Stanley Chu