Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 15 Dec 2020 13:25:28 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     Julia Lawall <julia.lawall@inria.fr>
Cc:     Wolfram Sang <wsa@the-dreams.de>, michal.lkml@markovi.net,
        Gilles.Muller@lip6.fr, Mark Brown <broonie@kernel.org>,
        nicolas.palix@imag.fr, linux-kernel@vger.kernel.org,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Julia Lawall <Julia.Lawall@lip6.fr>,
        Tomi Valkeinen <tomi.valkeinen@ti.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        cocci@systeme.lip6.fr
Subject: Re: [Cocci] [PATCH] coccinnelle: Remove ptr_ret script
Message-ID: <20201215122528.tvkess3nav3uc4uy@gilmour>
References: <20200107073629.325249-1-maxime@cerno.tech>
 <alpine.DEB.2.21.2001071106420.3004@hadrien>
 <20200107102954.GB1135@ninjato>
 <20201215084823.towbaqay5tgdh7dw@gilmour>
 <alpine.DEB.2.22.394.2012150950440.2879@hadrien>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="5lcstcw72h33y6eo"
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.22.394.2012150950440.2879@hadrien>
Precedence: bulk


--5lcstcw72h33y6eo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 15, 2020 at 09:52:36AM +0100, Julia Lawall wrote:
>=20
>=20
> On Tue, 15 Dec 2020, Maxime Ripard wrote:
>=20
> > Hi,
> >
> > On Tue, Jan 07, 2020 at 11:29:54AM +0100, Wolfram Sang wrote:
> > > On Tue, Jan 07, 2020 at 11:06:56AM +0100, Julia Lawall wrote:
> > > >
> > > >
> > > > On Tue, 7 Jan 2020, Maxime Ripard wrote:
> > > >
> > > > > The ptr_ret script script addresses a number of situations where =
we end up
> > > > > testing an error pointer, and if it's an error returning it, or r=
eturn 0
> > > > > otherwise to transform it into a PTR_ERR_OR_ZERO call.
> > > > >
> > > > > So it will convert a block like this:
> > > > >
> > > > > if (IS_ERR(err))
> > > > >     return PTR_ERR(err);
> > > > >
> > > > > return 0;
> > > > >
> > > > > into
> > > > >
> > > > > return PTR_ERR_OR_ZERO(err);
> > > > >
> > > > > While this is technically correct, it has a number of drawbacks. =
First, it
> > > > > merges the error and success path, which will make it harder for =
a reviewer
> > > > > or reader to grasp.
> > > > >
> > > > > It's also more difficult to extend if we were to add some code be=
tween the
> > > > > error check and the function return, making the author essentiall=
y revert
> > > > > that patch before adding new lines, while it would have been a tr=
ivial
> > > > > addition otherwise for the rewiever.
> > > > >
> > > > > Therefore, since that script is only about cosmetic in the first =
place,
> > > > > let's remove it since it's not worth it.
> > > > >
> > > > > Cc: Jani Nikula <jani.nikula@linux.intel.com>
> > > > > Cc: Thierry Reding <thierry.reding@gmail.com>
> > > > > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > > > > Cc: Mark Brown <broonie@kernel.org>
> > > > > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> > > >
> > > > Acked-by: Julia Lawall <julia.lawall@inria.fr>
> > >
> > > Convincing patch description, good catch!
> > >
> > > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> >
> > It looks like this patch was never applied, whose tree should it go
> > through?
>=20
> Sorry.  I can take it.  I'm not sure that I still have the original
> message, though.  If you have it handy, that would be helpful.

Sure, I just sent a new version with all the tags

Thanks!
Maxime

--5lcstcw72h33y6eo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX9irOAAKCRDj7w1vZxhR
xdyZAQDzVBVndsiZlVl3kpwfpz/3+6pNB1QKT7x6IGkV57YMrgD7B53xu+cJtvNE
4AYbaLHVlIe4o746cPMHUAdOZviNxgY=
=xT3J
-----END PGP SIGNATURE-----

--5lcstcw72h33y6eo--