Date: Mon, 4 Sep 2006 15:02:41 +1000
From: Nathan Scott <nathans@sgi.com>
To: Richard Knutsson <ricknu-0@student.ltu.se>
Cc: akpm@osdl.org, xfs-masters@oss.sgi.com, xfs@oss.sgi.com,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.18-rc4-mm3 2/2] fs/xfs: Converting into generic boolean
Message-ID: <20060904150241.I3335706@wobbly.melbourne.sgi.com>
References: <44F833C9.1000208@student.ltu.se>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <44F833C9.1000208@student.ltu.se>; from ricknu-0@student.ltu.se on Fri, Sep 01, 2006 at 03:21:13PM +0200
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 988
Lines: 31

On Fri, Sep 01, 2006 at 03:21:13PM +0200, Richard Knutsson wrote:
> From: Richard Knutsson <ricknu-0@student.ltu.se>
> 
> Converting:
> 'B_FALSE' into 'false'
> 'B_TRUE'  into 'true'
> 'boolean_t' into 'bool'

Hmm, so your bool is better than the next guys bool[ean[_t]]? :)

Seems like it'll be a few more days until the next cleanup patch
to remove _that_, so we shouldn't go that path.  Since we do use
the current boolean_t somewhat inconsistently in XFS, I'd say we
should just toss the thing and use int.

I took the earlier patch and completed it, switching over to int
use in place of boolean_t in the few places it used - I'll merge
that at some point, when its had enough testing.

cheers.

-- 
Nathan

-- 
VGER BF report: U 0.496999
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/