Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp3453662pxu; Tue, 15 Dec 2020 07:24:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJyfbr2pfSe1xFNoXoPc/V/K4rv+lVBFBpQB/sB1k64Z7Q4Koy6AVIo3FEGFh1olIsiM4/xp X-Received: by 2002:a17:906:7104:: with SMTP id x4mr27889883ejj.141.1608045848847; Tue, 15 Dec 2020 07:24:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608045848; cv=none; d=google.com; s=arc-20160816; b=b5suEON/E2iHEe0DBNOhiWxTfS0A0HtE0SesmRhV2WNRzuYiATwKE3wf0ROePnjo4C eN+z6aL65NUukbbYGYY7MzXdo8NTs8vQr8plWNA0mOW+ub5oZcLMVOTY4eFUmMkK5DaE Fu2PLIJmI4Yaa0O0HUtE9L3QmUcLopYQsKQVADTV0gbNZZkxJPLO42AaV4NV3xAIynFY bdd/vAjQhuhv3U8URA6LLdghYyZ05mFjQNh4/xMUzcnUEC5XHZImf86/7ZEcisx82tJB WQWZnyH5snVC1M8FjxyIMELemw2E72qOko7Nfbc0QdBFteFAR86XFmrtUQ5MYpGDBJ/Y bkvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :to:subject:dkim-signature; bh=IiBIuwWLd+/N9utzdTqFy9iYAwPYd+SNDmJ8szz0ebs=; b=prBROLV1isa/q8uXsGtUy0SWb+lVVuTO516YpF1jXK/S4gqznVWfEFqlZXXa2DfYsU Zc7qbBBwwXmS9g1JqwSnHziyf0UTXp3SZ5scMvw5szVX67klo45ixdDERrfic5iHMT7/ tgXxyP8zPieHCKrukEwW29RDwJJYVKVP0odVsHmshfwOhvSUxikwJMA71sR2fZxIqlmO rC8IRuSLGTDfi84IEEGr+lJeVyRwThGZZa9I/16oW9SKOVcQW6oem3pVhdEjN8UxrtwK 4BWb5R4SQqmoITV/cL06vmBKa2YXDwkiWfnVZEqjLbiFNkK5Yb0idvC5Ay0TsZwTDNmy ZrQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="pQ00NHK/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j13si1000170edt.512.2020.12.15.07.23.42; Tue, 15 Dec 2020 07:24:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="pQ00NHK/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729629AbgLOPVK (ORCPT + 99 others); Tue, 15 Dec 2020 10:21:10 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:39404 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729150AbgLOPVK (ORCPT ); Tue, 15 Dec 2020 10:21:10 -0500 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0BFFJHNi087003; Tue, 15 Dec 2020 09:19:17 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1608045557; bh=IiBIuwWLd+/N9utzdTqFy9iYAwPYd+SNDmJ8szz0ebs=; h=Subject:To:References:From:Date:In-Reply-To; b=pQ00NHK/AGDChuYikM5txlxbm6K/Gsuv9OUh976s6BwIw5y4BgzwEvaPV9eI4N7z+ /aUXPCpvmvAUYT3B1uxRnG3IEuAQV+CKwH7atALj79PuP0E17+Qop/w2ep3xg5ELHQ BHnzkSFZ4ALLDCeKJqmE5PG7/8BWFwUDZEnsQFEc= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0BFFJHax045012 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 15 Dec 2020 09:19:17 -0600 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 15 Dec 2020 09:19:17 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 15 Dec 2020 09:19:17 -0600 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0BFFJFJ8104203; Tue, 15 Dec 2020 09:19:16 -0600 Subject: Re: [PATCH -next] drm: omapdrm: Delete useless kfree code To: Zheng Yongjun , , , , References: <20201214134628.4937-1-zhengyongjun3@huawei.com> From: Tomi Valkeinen Message-ID: Date: Tue, 15 Dec 2020 17:19:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201214134628.4937-1-zhengyongjun3@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/12/2020 15:46, Zheng Yongjun wrote: > The parameter of kfree function is NULL, so kfree code is useless, delete it. > > Signed-off-by: Zheng Yongjun > --- > drivers/gpu/drm/omapdrm/tcm-sita.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/omapdrm/tcm-sita.c b/drivers/gpu/drm/omapdrm/tcm-sita.c > index 817be3c41863..af59e9c03917 100644 > --- a/drivers/gpu/drm/omapdrm/tcm-sita.c > +++ b/drivers/gpu/drm/omapdrm/tcm-sita.c > @@ -254,6 +254,5 @@ struct tcm *sita_init(u16 width, u16 height) > return tcm; > > error: > - kfree(tcm); > return NULL; > } Thanks, I'll merge this. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki