Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932420AbWIDHNM (ORCPT ); Mon, 4 Sep 2006 03:13:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932419AbWIDHNM (ORCPT ); Mon, 4 Sep 2006 03:13:12 -0400 Received: from mailer.gwdg.de ([134.76.10.26]:59825 "EHLO mailer.gwdg.de") by vger.kernel.org with ESMTP id S932415AbWIDHNJ (ORCPT ); Mon, 4 Sep 2006 03:13:09 -0400 Date: Mon, 4 Sep 2006 09:09:15 +0200 (MEST) From: Jan Engelhardt To: Josef Sipek cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, hch@infradead.org, akpm@osdl.org, viro@ftp.linux.org.uk Subject: Re: [PATCH 08/22][RFC] Unionfs: Directory manipulation helper functions In-Reply-To: <20060901014708.GI5788@fsl.cs.sunysb.edu> Message-ID: References: <20060901013512.GA5788@fsl.cs.sunysb.edu> <20060901014708.GI5788@fsl.cs.sunysb.edu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Report: Content analysis: 0.0 points, 6.0 required _SUMMARY_ Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 860 Lines: 33 >+/* This filldir function makes sure only whiteouts exist within a directory. */ >+static int readdir_util_callback(void *dirent, const char *name, int namelen, >+ loff_t offset, ino_t ino, unsigned int d_type) >+{ >+ int err = 0; >+ struct unionfs_rdutil_callback *buf = >+ (struct unionfs_rdutil_callback *)dirent; Nocast. >+ if ((namelen > UNIONFS_WHLEN) && !strncmp(name, UNIONFS_WHPFX, UNIONFS_WHLEN)) { () Also elsewhere. >+ if (0 <= bopaque && bopaque < bend) Turn it. Constant values are usually wanted on the right side. bopaque >= 0 Jan Engelhardt -- -- VGER BF report: H 1.55431e-15 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/