Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 15 Dec 2020 17:18:38 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Michael Petlan <mpetlan@redhat.com>,
        Ian Rogers <irogers@google.com>,
        Stephane Eranian <eranian@google.com>,
        Alexei Budankov <abudankov@huawei.com>
Subject: Re: [PATCH 2/3] perf tools: Allow to enable/disable events via
 control file
Message-ID: <20201215161838.GA698181@krava>
References: <20201210204330.233864-1-jolsa@kernel.org>
 <20201210204330.233864-3-jolsa@kernel.org>
 <20201215151413.GE252952@kernel.org>
 <20201215152420.GC658008@krava>
 <20201215160332.GN258566@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201215160332.GN258566@kernel.org>
Precedence: bulk

On Tue, Dec 15, 2020 at 01:03:32PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Dec 15, 2020 at 04:24:20PM +0100, Jiri Olsa escreveu:
> > On Tue, Dec 15, 2020 at 12:14:13PM -0300, Arnaldo Carvalho de Melo wrote:
> > > Em Thu, Dec 10, 2020 at 09:43:29PM +0100, Jiri Olsa escreveu:
> > > > Adding new control events to enable/disable specific event.
> > > > The interface string for control file are:
> > > > 
> > > >   'enable-<EVENT NAME>'
> > > >   'disable-<EVENT NAME>'
> > > 
> > > Wwy do we have "enable-" as the "tag" for this?
> > 
> > the whole 'enable-' is prefix for command that enables specific event
> > following '-' starts the event name
> > 
> > > 
> > > Also is it possible to use "enable sched:*" and have that match what is
> > > in the evlist and enable (or disable, if using "disable sched:*") what
> > > matches?
> > 
> > yep, that should be possible to add
> > 
> > > 
> > > This second suggestion can be done on top of this, i.e. as an
> > > enhancement, but mixing up the command (enable, disable) with its
> > > arguments looks strange.
> > 
> > the '-' determines that there's event name following,
> > pure 'enable' switches on everything
> 
> I see it, but why not use the more natural ' ' space to separate the
> command from its arguments? Just like in a bash command line, say?
> 
> I.e. why not:
> 
>   enable
> 
> to enable everything, and:
> 
>   enable sched:sched_switch
> 
> To enable just the "sched:sched_switch" event?

right, that's we discussed in the other patch thread,
I'll make the change

thanks,
jirka