Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 15 Dec 2020 17:27:01 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Michael Petlan <mpetlan@redhat.com>,
        Ian Rogers <irogers@google.com>,
        Stephane Eranian <eranian@google.com>,
        Alexei Budankov <abudankov@huawei.com>
Subject: Re: [PATCH 3/3] perf tools: Add evlist/evlist-verbose control
 commands
Message-ID: <20201215162701.GB698181@krava>
References: <20201210204330.233864-1-jolsa@kernel.org>
 <20201210204330.233864-4-jolsa@kernel.org>
 <20201215152343.GG252952@kernel.org>
 <20201215155911.GD658008@krava>
 <20201215160933.GO258566@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201215160933.GO258566@kernel.org>
Precedence: bulk

On Tue, Dec 15, 2020 at 01:09:33PM -0300, Arnaldo Carvalho de Melo wrote:

SNIP

> > instead of:
>  
> >   echo 'enable-cycles' > control
>  
> > I'd like to avoid any elaborate parsing logic..
>  
> > how about that?
> 
> Use space to separate command from its arguments, keep the same
> experience as:
> 
> [acme@quaco ~]$ perf evlist -h
> 
>  Usage: perf evlist [<options>]
> 
>     -f, --force           don't complain, do it
>     -F, --freq            Show the sample frequency
>     -g, --group           Show event group information
>     -i, --input <file>    Input file name
>     -v, --verbose         Show all event attr details
>         --trace-fields    Show tracepoint fields
> 
> [acme@quaco ~]$
> 
> and:
> 
> echo "evlist arguments"
> 
> ?
> 
> Fits the bill :-)

ok

> 
> The experience users have on existing commands, the same arguments, etc.
> 
> Even -h can have its uses, i.e. has this daemon support for some option
> or is it an old version?

Alexei just suggested to add 'stop' control command and use it
instead of kill signal, which is good idea

but other than that daemon just opens the control file and
shows its path

jirka