Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Yazen Ghannam <Yazen.Ghannam@amd.com>
To:     linux-edac@vger.kernel.org
Cc:     Yazen Ghannam <Yazen.Ghannam@amd.com>,
        linux-kernel@vger.kernel.org, bp@alien8.de,
        Smita.KoralahalliChannabasappa@amd.com
Subject: [PATCH] EDAC/amd64: Tone down messages about missing PCI IDs
Date:   Tue, 15 Dec 2020 17:01:31 +0000
Message-Id: <20201215170131.8496-1-Yazen.Ghannam@amd.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from yaz-ethanolx.amd.com (165.204.78.2) by SN6PR01CA0007.prod.exchangelabs.com (2603:10b6:805:b6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Tue, 15 Dec 2020 17:01:43 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: ceab0811-f87f-4bfa-e758-08d8a11b19ca
X-MS-TrafficTypeDiagnostic: BN8PR12MB2977:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BN8PR12MB2977964CE07CDCAC328A0162F8C60@BN8PR12MB2977.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: hl6u/ijQzcDyFIleR0JXLKrgHFGhB85oJN9dZ/90EjH9FLBTzxk1jmgaUG3w3GI8WdS6FcejaLasVQ5iskrpYm5gVAUTLcNATPau09L/Dso9G0ZoGYHNQ59/iII85EW37kYp4LyVJJn1BZZ++aVdMGRnqBb8l0e4u8YoRV6tPFcmgqqNKkpL0q8IUn2mX42IA07kpTy6P1e85Ez7En4o8pfBS5KrMQvRdC5fkMUywtZfWpTVjvTouEV7WtdrnHEIvTgxd2Nz/GgjNhJPvZ2EVijqBA/V1O7yX8v9gzsIpggbR93ST0sw+JKV+692TIti1DOoT1jr61wqe0T14H3YrTIyRpQUHdCXFv4i8Q1gohxWeoxGXt5BKu1zz2ABkMpk
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR12MB3108.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(136003)(346002)(366004)(26005)(8676002)(34490700003)(2906002)(52116002)(4326008)(15650500001)(7696005)(36756003)(86362001)(83380400001)(6486002)(6916009)(66946007)(2616005)(1076003)(5660300002)(66556008)(16526019)(6666004)(66476007)(186003)(956004)(508600001)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?1RlPlX5h3mxaS8UKkTWPmDF8WepoA8kj5zOardu7VySjAdgfw72iHEWQbU1g?=
 =?us-ascii?Q?H71ZkWkvBrNETmcpLp3DytO7dMwfIFXsyb+CHW18PDn4r9AWSprmyMjLK6Ix?=
 =?us-ascii?Q?pRyjMnSNs/W0crLdlX5IIuqqT6HH3NJbrnYWzYJkdQmPRm89WLoiqK+ENKLm?=
 =?us-ascii?Q?eqEIq2tppek5rAaz96IHhaZBj57nEGB0k7ghh9se5EBd0oNf0RZPL3QysCOv?=
 =?us-ascii?Q?YhJ7iwXNg9Wqx3Dh3UpJRDWf6V4y9v2w3DhaRJbR3iGUZADzNiicDPfqftMc?=
 =?us-ascii?Q?AZCQXn34y9rhLz6kOmzMzCRYDXdzczu/4pz1r/gTQyxiUlD6di1XOm3FwY4A?=
 =?us-ascii?Q?AKePAHzWWW4KdhP9GEmhHhJZ+MwfsXtJYNUB7+tgj/UriGxo0DaEk6sHqsrl?=
 =?us-ascii?Q?oGDcqBO/CvwbTJx+9Hiy8Ol/cHHiypcSIJVQfItRIyHuh1hTnU2qyELTQ6An?=
 =?us-ascii?Q?KY762yTOa1VQqeEzC4DV6A2ivkzgdVw3j0BCN8Xfowaw8NKebx6ajnmi0Qtn?=
 =?us-ascii?Q?YpR1Wr27ZWn4lUZlNEcpseX3SFqXlS3R0sUhgv6Tzo+YKpjP0R6zBpleJ0f6?=
 =?us-ascii?Q?9+0RXTd3XSML1Ren9cdlBOSOIBH7aLs+SfS5kPf+OSoj68J8p3/8S8x7cuyx?=
 =?us-ascii?Q?5RYAutqC5ayrjjjUTf7mr8dkNnKPt11AjmSnqQcU5Dgjz8CZ2vhMD+3qvgmC?=
 =?us-ascii?Q?ckcmva2qkedSH54NUkux1i0dJjcLa5FDzW8EactnlpB3a/BnNnkdcvXevu8s?=
 =?us-ascii?Q?GW9UHNuziIkzzODSwnOQXJL9hq7M6wDuqPTa5wbuMdS4N/gzVjlexu6sgQvu?=
 =?us-ascii?Q?9c0oonIZknXKVIJxtEP4w2C/+eeQ24n9CFrTt+3mUh7jES0+/ciWsgf1jH+k?=
 =?us-ascii?Q?3DrogmLF+DrRBEmUrj7QjhnedmE4oKYQxSs36JzDrKB8RLlcB9dGQmGAMAJ3?=
 =?us-ascii?Q?+a8+8zKW88yTz4PLLVFl1y3WOZ7at3WykI0xBL0O1MlYrvj+1bY2udoPQkFq?=
 =?us-ascii?Q?2sry?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2020 17:01:44.0472
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-Network-Message-Id: ceab0811-f87f-4bfa-e758-08d8a11b19ca
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xa30XU6BFplP0/VNIcVvUESQoh/ULxyg3Eq2AqmrgbChwQlSOjrR1KP9Plo/BBEPx2s1FdYfumE0S6PsuxWPmg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB2977
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Yazen Ghannam <yazen.ghannam@amd.com>

Give these messages a debug severity as they are really only useful to
the module developers.

Also, drop the "(broken BIOS?)" phrase, since this can cause churn for
BIOS folks. The PCI IDs needed by the module, at least on modern systems,
are fixed in hardware.

Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
---
 drivers/edac/amd64_edac.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index f7087ddddb90..a3770ffee2ea 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -2665,7 +2665,7 @@ reserve_mc_sibling_devs(struct amd64_pvt *pvt, u16 pci_id1, u16 pci_id2)
 	if (pvt->umc) {
 		pvt->F0 = pci_get_related_function(pvt->F3->vendor, pci_id1, pvt->F3);
 		if (!pvt->F0) {
-			amd64_err("F0 not found, device 0x%x (broken BIOS?)\n", pci_id1);
+			edac_dbg(1, "F0 not found, device 0x%x\n", pci_id1);
 			return -ENODEV;
 		}
 
@@ -2674,7 +2674,7 @@ reserve_mc_sibling_devs(struct amd64_pvt *pvt, u16 pci_id1, u16 pci_id2)
 			pci_dev_put(pvt->F0);
 			pvt->F0 = NULL;
 
-			amd64_err("F6 not found: device 0x%x (broken BIOS?)\n", pci_id2);
+			edac_dbg(1, "F6 not found: device 0x%x\n", pci_id2);
 			return -ENODEV;
 		}
 
@@ -2691,7 +2691,7 @@ reserve_mc_sibling_devs(struct amd64_pvt *pvt, u16 pci_id1, u16 pci_id2)
 	/* Reserve the ADDRESS MAP Device */
 	pvt->F1 = pci_get_related_function(pvt->F3->vendor, pci_id1, pvt->F3);
 	if (!pvt->F1) {
-		amd64_err("F1 not found: device 0x%x (broken BIOS?)\n", pci_id1);
+		edac_dbg(1, "F1 not found: device 0x%x\n", pci_id1);
 		return -ENODEV;
 	}
 
@@ -2701,7 +2701,7 @@ reserve_mc_sibling_devs(struct amd64_pvt *pvt, u16 pci_id1, u16 pci_id2)
 		pci_dev_put(pvt->F1);
 		pvt->F1 = NULL;
 
-		amd64_err("F2 not found: device 0x%x (broken BIOS?)\n", pci_id2);
+		edac_dbg(1, "F2 not found: device 0x%x\n", pci_id2);
 		return -ENODEV;
 	}
 
-- 
2.25.1