Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp3557065pxu; Tue, 15 Dec 2020 09:39:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJwrAy9z4ByAAi5DisnOWGr06oCuTKljifLjuKDDmOV7UW97cEKWdRW8Y0tEHKN9Iyvikf3g X-Received: by 2002:aa7:c652:: with SMTP id z18mr3398430edr.60.1608053991131; Tue, 15 Dec 2020 09:39:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608053991; cv=none; d=google.com; s=arc-20160816; b=ci4mMk6ODZ/vfmjULoqK3d7+HA7IWaCzYaBJUo71RUPfTo+EzwiwynOEmqM19bYVNU iII42M5eOUzKKcc+12vZuQ/XfLfjXlTGSu7acT1urmX5JQ5yarNdFCuTJGPQEJ+gDiJf 7vtPGz8ZOGpP2cfmfbTzbxfBch3Aq5fjfpFtzL5kHSQ8fLyHe1IBODSbp+yfqVdx9aB9 1vifdRo0yPJ/inXC1EFtXosQoatYqIRXD8eJ/zzuBEDfpVoSnp3tre4ZWFMqwpCx+Un1 G5AZE/bgY78CW8pHmOsTlqe6928wRhct0tiQ+PojfHh3P5P0Uy9iPx47eM6VNPRDnyTP yHfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=gl/aWc6w2SA8IZcaPBPbO6KBwRYEeiTeid8Ze3UocIU=; b=k0KXfXIfzxz8kKMwWz1Cm1h42fX8YNwHMivLnCIVgqYka1R2S4eayFiui4U65RQqMA AggXY/U6HK6+V9uKvKfoCbSc4ig8oplP0+KT8QUHj7dqqTS84Q0kwCWJf9UXkhuxH8c+ 8HNY8gkaCWo9xZBuL9+nbRBmCo7FSDdP0U9lD8oTYrMcoRfqKRufDJJvI/q3TtGmx326 UCpAGR0yUD638bCj+dzhbfETOyt7FfShKZqO4/pKxj3LAIGgAIRD++mUU1cNRhEgiUBd P4GdxIzXXgfhzJOpgXOp2tal0WbALy43CmzgjcHEw9eEgnzc/+EdFNyGmphLhYaxYNfv 5CWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=ZaoDvg8w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t23si1470208ejs.184.2020.12.15.09.39.27; Tue, 15 Dec 2020 09:39:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=ZaoDvg8w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730551AbgLORd3 (ORCPT + 99 others); Tue, 15 Dec 2020 12:33:29 -0500 Received: from smtprelay-out1.synopsys.com ([149.117.87.133]:46068 "EHLO smtprelay-out1.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731297AbgLORbt (ORCPT ); Tue, 15 Dec 2020 12:31:49 -0500 Received: from mailhost.synopsys.com (mdc-mailhost1.synopsys.com [10.225.0.209]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id DE665C04DA; Tue, 15 Dec 2020 17:30:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1608053449; bh=ZCFeUiaOqr6nmVdSrA/yeLCZ+L/gs597171/4LwdJCg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:In-Reply-To: References:From; b=ZaoDvg8wbB8lCJwqvd7TcwYJEpkV+2//cfQTiz+RHVEC+jMYRlc+izTY8ju7EOoA0 Ucu4KqBspALgJaI821QKEyJNXNFci8CobzLMbon9298Yco7m+SocDx7HrN8/stwnF9 xDA7cekeWAmWICbA87U5jAqTYKd4TbS65SXnZNgMSdCWKefnN4twArukNMdYzgfH+2 +E5h93VzSXxiIg26AarKgzS5hgY3P1xNPQeBTQ8SnIeLnVAub7p+2akL1jOK0BdcvI jrfCyWa+S7jeNAGeMQ2M8AUgCDjDOnzE8O2rcqq5X1lgDjEihfB+RnCXPniIlRpozk p0KIKYv9dCBcg== Received: from de02dwia024.internal.synopsys.com (de02dwia024.internal.synopsys.com [10.225.19.81]) by mailhost.synopsys.com (Postfix) with ESMTP id 73759A024A; Tue, 15 Dec 2020 17:30:47 +0000 (UTC) X-SNPS-Relay: synopsys.com From: Gustavo Pimentel To: Gustavo Pimentel , Vinod Koul , Dan Williams Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 15/15] dmaengine: dw-edma: Add pcim_iomap_table return checker Date: Tue, 15 Dec 2020 18:30:24 +0100 Message-Id: <6df68db09ac19b2be8559e848497714ee763d5bd.1608053262.git.gustavo.pimentel@synopsys.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Detected by CoverityScan CID 16555 ("Dereference null return") Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-pcie.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c index 1fa43e3..b759796 100644 --- a/drivers/dma/dw-edma/dw-edma-pcie.c +++ b/drivers/dma/dw-edma/dw-edma-pcie.c @@ -238,6 +238,9 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, dw->rd_ch_cnt = vsec_data.rd_ch_cnt; dw->rg_region.vaddr = pcim_iomap_table(pdev)[vsec_data.rg.bar]; + if (!dw->rg_region.vaddr) + return -ENOMEM; + dw->rg_region.vaddr += vsec_data.rg.off; dw->rg_region.paddr = pdev->resource[vsec_data.rg.bar].start; dw->rg_region.paddr += vsec_data.rg.off; @@ -250,12 +253,18 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, struct dw_edma_block *dt_block = &vsec_data.dt_wr[i]; ll_region->vaddr = pcim_iomap_table(pdev)[ll_block->bar]; + if (!ll_region->vaddr) + return -ENOMEM; + ll_region->vaddr += ll_block->off; ll_region->paddr = pdev->resource[ll_block->bar].start; ll_region->paddr += ll_block->off; ll_region->sz = ll_block->sz; dt_region->vaddr = pcim_iomap_table(pdev)[dt_block->bar]; + if (!dt_region->vaddr) + return -ENOMEM; + dt_region->vaddr += dt_block->off; dt_region->paddr = pdev->resource[dt_block->bar].start; dt_region->paddr += dt_block->off; @@ -269,12 +278,18 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, struct dw_edma_block *dt_block = &vsec_data.dt_rd[i]; ll_region->vaddr = pcim_iomap_table(pdev)[ll_block->bar]; + if (!ll_region->vaddr) + return -ENOMEM; + ll_region->vaddr += ll_block->off; ll_region->paddr = pdev->resource[ll_block->bar].start; ll_region->paddr += ll_block->off; ll_region->sz = ll_block->sz; dt_region->vaddr = pcim_iomap_table(pdev)[dt_block->bar]; + if (!dt_region->vaddr) + return -ENOMEM; + dt_region->vaddr += dt_block->off; dt_region->paddr = pdev->resource[dt_block->bar].start; dt_region->paddr += dt_block->off; -- 2.7.4