Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp3558260pxu; Tue, 15 Dec 2020 09:41:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJzM+9JXguxzyhrDdk2haQ4RFwnIFO+cSbVzeRVN66qNgX1y8Jf+05twscJgIk1j8J3TAQyB X-Received: by 2002:a17:906:604e:: with SMTP id p14mr27821401ejj.543.1608054093246; Tue, 15 Dec 2020 09:41:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608054093; cv=none; d=google.com; s=arc-20160816; b=Jj1XHJj8fBm1Ngo+GM7QyyhrJlunMQH2irWk1T5LezhSW+aHf5uhC8rY2mgqELt2nS GZfEwOdggCSnrFQMdfoUUJneoPaMKoOFG3+xdda8DkYMi7dx2Sv7BCWAkaMP4QdEhs0k SB9nhqHh6Xxfv/v4uiJnjtqgOJR2aSmv0BDFRJI3TI70R4lCmWnCaZKyKGqszsG+r9XK iZCm7VMwaLz+ObG8ddruvgJXuxXD2DGeaidiEXZJxe79JCTpkTgn+HqkRUaVXzc3nZYj GavPeyggbGcWXp0+F19dEHGK7aR2vhN+ol7od7Xip0v8GT93nNiCIZnDC2sKfDP8+NE9 0U7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=LeJkYXCorWtiaP+yCGj+HszRDmiDY/6LzTvN7R0PDJU=; b=BL6SbcHkd57h5z4eJCUyxhysz7Bb1zYzRuuRKBE/sQaU9rur8SB2iIIfruWdvyYbs6 JrrgOIP0GAKJX92zN2zJItbMcHhOmfPPwI1jP7gbYkztFX6aaBkNpKwmn53usngMXfo8 B9378IvROWGP87IxtochWrs88zrAsv81yvVhw4PuOIp56EmvbDhVfIgT0o6fDqgNVvke 3ferztnemMGahxwymNiv4gOdnUyf2d0T65uVdEW5jhqyDON3Jng2olmdCpPOKlkhy9aC 4p94mXrMRyohDHrND0dNqQhY08Q75asPwmeQiM6mhhanYe75HJOTQVqPjAg4CZg8wQG7 NiHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=HuUgsMsu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b20si1259760ejk.726.2020.12.15.09.41.09; Tue, 15 Dec 2020 09:41:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=HuUgsMsu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730153AbgLORgq (ORCPT + 99 others); Tue, 15 Dec 2020 12:36:46 -0500 Received: from smtprelay-out1.synopsys.com ([149.117.73.133]:54442 "EHLO smtprelay-out1.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731289AbgLORbq (ORCPT ); Tue, 15 Dec 2020 12:31:46 -0500 Received: from mailhost.synopsys.com (mdc-mailhost1.synopsys.com [10.225.0.209]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id 742E240476; Tue, 15 Dec 2020 17:30:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1608053446; bh=71t8kLn/h4uRT+rZrsVOIM9WjcoyjC97XsyNd4xo0/8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:In-Reply-To: References:From; b=HuUgsMsuLEO9vN/oLpFFd64Zo/Lspv/eMNDAnfOaiTxniSA8gQET3IunQiD4MI47z imXKsIWSBvrbZ4Vt1wpy79u9po+5cOCXW1rLSU2qAZycUTpifBGBKFoxei498HQ1MH ycCoMaDCwjOPo+KLoH78MOxhv8zvW8tAUFVnvdV8lqYE6VAOlU2poqbEOVSkEWNuDF mIVEGkGnO4JrvH1OIRvTFZ9EQOMBfhgsVOmYiA9e9SMoFvBbugdVwuy30ZStXVnHF9 h4vxbO0HxxCep37eabbglneohB+2GovV76N/p547o6431q5bEhGVpt+PZLzd44viFW cTqIAY4ejaj7g== Received: from de02dwia024.internal.synopsys.com (de02dwia024.internal.synopsys.com [10.225.19.81]) by mailhost.synopsys.com (Postfix) with ESMTP id 51D56A024A; Tue, 15 Dec 2020 17:30:45 +0000 (UTC) X-SNPS-Relay: synopsys.com From: Gustavo Pimentel To: Gustavo Pimentel , Dan Williams , Vinod Koul Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 12/15] dmaengine: dw-edma: Fix crash on loading/unloading driver Date: Tue, 15 Dec 2020 18:30:21 +0100 Message-Id: <615cabee7443a8f6fd054e6bf18c75985e81131c.1608053262.git.gustavo.pimentel@synopsys.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When the driver is compiled as a module and loaded if we try to unload it, the Kernel shows a crash log. This Kernel crash is due to the dma_async_device_unregister() call done after deleting the channels, this patch fixes this issue. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c index 8d8292e..f7a1930 100644 --- a/drivers/dma/dw-edma/dw-edma-core.c +++ b/drivers/dma/dw-edma/dw-edma-core.c @@ -986,22 +986,21 @@ int dw_edma_remove(struct dw_edma_chip *chip) /* Power management */ pm_runtime_disable(dev); + /* Deregister eDMA device */ + dma_async_device_unregister(&dw->wr_edma); list_for_each_entry_safe(chan, _chan, &dw->wr_edma.channels, vc.chan.device_node) { - list_del(&chan->vc.chan.device_node); tasklet_kill(&chan->vc.task); + list_del(&chan->vc.chan.device_node); } + dma_async_device_unregister(&dw->rd_edma); list_for_each_entry_safe(chan, _chan, &dw->rd_edma.channels, vc.chan.device_node) { - list_del(&chan->vc.chan.device_node); tasklet_kill(&chan->vc.task); + list_del(&chan->vc.chan.device_node); } - /* Deregister eDMA device */ - dma_async_device_unregister(&dw->wr_edma); - dma_async_device_unregister(&dw->rd_edma); - /* Turn debugfs off */ dw_edma_v0_core_debugfs_off(chip); -- 2.7.4