Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201215164315.3666-1-calvin.johnson@oss.nxp.com> <20201215164315.3666-9-calvin.johnson@oss.nxp.com>
In-Reply-To: <20201215164315.3666-9-calvin.johnson@oss.nxp.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 15 Dec 2020 19:53:26 +0200
Message-ID: <CAHp75Vf69NuxqcJntQi+CT1QN4cpdr2LYNzo6=t-pBWcWgufPA@mail.gmail.com>
Subject: Re: [net-next PATCH v2 08/14] net: mdiobus: Introduce fwnode_mdiobus_register()
To:     Calvin Johnson <calvin.johnson@oss.nxp.com>
Cc:     Grant Likely <grant.likely@arm.com>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Jeremy Linton <jeremy.linton@arm.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Russell King - ARM Linux admin <linux@armlinux.org.uk>,
        Cristi Sovaiala <cristian.sovaiala@nxp.com>,
        Florin Laurentiu Chiculita <florinlaurentiu.chiculita@nxp.com>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        Madalin Bucur <madalin.bucur@oss.nxp.com>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Marcin Wojtas <mw@semihalf.com>,
        Pieter Jansen Van Vuuren <pieter.jansenvv@bamboosystems.io>,
        Jon <jon@solid-run.com>, "linux.cj" <linux.cj@gmail.com>,
        Laurentiu Tudor <laurentiu.tudor@nxp.com>,
        Diana Madalina Craciun <diana.craciun@nxp.com>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        netdev <netdev@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Dec 15, 2020 at 6:44 PM Calvin Johnson
<calvin.johnson@oss.nxp.com> wrote:
>
> Introduce fwnode_mdiobus_register() to register PHYs on the  mdiobus.
> If the fwnode is DT node, then call of_mdiobus_register().
> If it is an ACPI node, then:
>         - disable auto probing of mdiobus
>         - register mdiobus
>         - save fwnode to mdio structure
>         - loop over child nodes & register a phy_device for each PHY

...

> +/**
> + * fwnode_mdiobus_register - Register mii_bus and create PHYs from fwnode
> + * @mdio: pointer to mii_bus structure
> + * @fwnode: pointer to fwnode of MDIO bus.
> + *
> + * This function registers the mii_bus structure and registers a phy_device
> + * for each child node of @fwnode.
> + */
> +int fwnode_mdiobus_register(struct mii_bus *mdio, struct fwnode_handle *fwnode)
> +{
> +       struct fwnode_handle *child;
> +       unsigned long long addr;
> +       acpi_status status;
> +       int ret;
> +
> +       if (is_of_node(fwnode)) {
> +               return of_mdiobus_register(mdio, to_of_node(fwnode));
> +       } else if (is_acpi_node(fwnode)) {

I would rather see this as simple as

     if (is_of_node(fwnode))
               return of_mdiobus_register(mdio, to_of_node(fwnode));
     if (is_acpi_node(fwnode))
               return acpi_mdiobus_register(mdio, fwnode);

where the latter one is defined somewhere in drivers/acpi/.

> +               /* Mask out all PHYs from auto probing. */
> +               mdio->phy_mask = ~0;
> +               ret = mdiobus_register(mdio);
> +               if (ret)
> +                       return ret;
> +
> +               mdio->dev.fwnode = fwnode;
> +       /* Loop over the child nodes and register a phy_device for each PHY */
> +               fwnode_for_each_child_node(fwnode, child) {

> +                       status = acpi_evaluate_integer(ACPI_HANDLE_FWNODE(child),
> +                                                      "_ADR", NULL, &addr);
> +                       if (ACPI_FAILURE(status)) {

Isn't it fwnode_get_id() now?

> +                               pr_debug("_ADR returned %d\n", status);
> +                               continue;
> +                       }

> +                       if (addr < 0 || addr >= PHY_MAX_ADDR)
> +                               continue;

addr can't be less than 0.

> +                       ret = fwnode_mdiobus_register_phy(mdio, child, addr);
> +                       if (ret == -ENODEV)
> +                               dev_err(&mdio->dev,
> +                                       "MDIO device at address %lld is missing.\n",
> +                                       addr);
> +               }
> +               return 0;
> +       }
> +       return -EINVAL;
> +}

-- 
With Best Regards,
Andy Shevchenko