Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp3584804pxu; Tue, 15 Dec 2020 10:17:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJyNv0qhZzuGuJRi4C+JS3Mm/ArHkE0LcNCNfUvFYzrffO4hB40tm3JoNqK5jArek2qerVrq X-Received: by 2002:a17:906:895:: with SMTP id n21mr27812318eje.52.1608056255829; Tue, 15 Dec 2020 10:17:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608056255; cv=none; d=google.com; s=arc-20160816; b=Dht2UVM5hEcWJHozhDv4JycMT6crAFDM/XHV3hzrCJYVMWetm/EYvpyMXSf/uygVWh P3MagL6iq3VPZTl38rA0zIkN3TJOvOrIzTDE6HqFfjjmsaEDoD7nf0yjF+UQFTMvmbZt QC+QuVe11Rs64Ocf2/WKoaBe+8vRgMBWzW90W7aQjZbZ14qkYdKZrXzKZv59Ghd9noU0 N6myIR9ScOV+vzYDd2Bhb6BrntgGVz7e5ZFGid7CvMdIY1Mo0CFRzabXbqPb+zewzLwL Sewh9bQwWTxB1eoP1Q9kMaRV8yvqVtOI2mafBAbLmxctpCvPdZF1/4nt3xgpJDa5UKnj ASvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version; bh=o3/4WhWVYxzYmbMVcOn3joNBOV7cuj8rhp6ZCE4d2pw=; b=Hgg0ajZoggN4ueqCH1UeQQer38rPinQ6Fu6ZIHCx3Sasw5ZymnAHgTXKXjfLsNgmBy Smu8Z8eo/orlcr55DYfq5SFvUkeedMSdXXTo8yuBvD6SlbNKw1m32JVy1pTBT+U9k3z/ ZYVgiZma9v3lHYv1Bc1T6cr1e1vHTzyHk9URAwRCi3PKG7tIRIDLIcXVY86NH2BRpg5s t20WVmvt1FJl2La5BgoJHwlwm9uDgTTmdQGzs+dc36ZKmEpTf4eS+tI/QB9peSePl1ou dhWnwL+TcsdmTPaYq+pqBtFkz3+iNyzeswyrYLfwFhx7x10jBaQb1eMTtIm+WmGkir/t gvSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p17si1268970ejw.23.2020.12.15.10.17.11; Tue, 15 Dec 2020 10:17:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731267AbgLOSOP convert rfc822-to-8bit (ORCPT + 99 others); Tue, 15 Dec 2020 13:14:15 -0500 Received: from mail.fireflyinternet.com ([77.68.26.236]:60675 "EHLO fireflyinternet.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1729759AbgLOSOK (ORCPT ); Tue, 15 Dec 2020 13:14:10 -0500 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 23336117-1500050 for multiple; Tue, 15 Dec 2020 18:13:09 +0000 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT In-Reply-To: <20201215144101.1878719-1-trix@redhat.com> References: <20201215144101.1878719-1-trix@redhat.com> Subject: Re: [PATCH] drm/i915: remove h from printk format specifier From: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Tom Rix To: airlied@linux.ie, daniel@ffwll.ch, daniele.ceraolospurio@intel.com, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, lionel.g.landwerlin@intel.com, rodrigo.vivi@intel.com, tejaskumarx.surendrakumar.upadhyay@intel.com, trix@redhat.com, tvrtko.ursulin@intel.com, venkata.s.dhanalakota@intel.com Date: Tue, 15 Dec 2020 18:13:10 +0000 Message-ID: <160805599050.14591.5854311082825914383@build.alporthouse.com> User-Agent: alot/0.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting trix@redhat.com (2020-12-15 14:41:01) > From: Tom Rix > > See Documentation/core-api/printk-formats.rst. > h should no longer be used in the format specifier for printk. It's understood by format_decode(). * 'h', 'l', or 'L' for integer fields At least reference commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") as to why the printk-formats.rst was altered so we know the code is merely in bad taste and not using undefined behaviour of printk. -Chris