Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751099AbWIDIZL (ORCPT ); Mon, 4 Sep 2006 04:25:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750890AbWIDIZK (ORCPT ); Mon, 4 Sep 2006 04:25:10 -0400 Received: from ns1.suse.de ([195.135.220.2]:58811 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S1750779AbWIDIZI (ORCPT ); Mon, 4 Sep 2006 04:25:08 -0400 From: Andreas Schwab To: Jan Engelhardt Cc: Josef Sipek , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, hch@infradead.org, akpm@osdl.org, viro@ftp.linux.org.uk Subject: Re: [PATCH 18/22][RFC] Unionfs: Superblock operations References: <20060901013512.GA5788@fsl.cs.sunysb.edu> <20060901015851.GS5788@fsl.cs.sunysb.edu> X-Yow: ...I think I'm having an overnight sensation right now!! Date: Mon, 04 Sep 2006 10:24:56 +0200 In-Reply-To: (Jan Engelhardt's message of "Mon, 4 Sep 2006 09:46:59 +0200 (MEST)") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 888 Lines: 36 Jan Engelhardt writes: >>+/* final actions when unmounting a file system */ >>+static void unionfs_put_super(struct super_block *sb) >>+{ >>+ int bindex, bstart, bend; >>+ struct unionfs_sb_info *spd; >>+ >>+ if ((spd = stopd(sb))) { > > Sugg.: > > if((spd = stopd(sb)) == NULL) > return; Better: spd = stopd(sb); if (!spd) return; Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra?e 5, 90409 N?rnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- VGER BF report: H 0 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/