Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] drm/i915: remove h from printk format specifier
To:     Chris Wilson <chris@chris-wilson.co.uk>, airlied@linux.ie,
        daniel@ffwll.ch, daniele.ceraolospurio@intel.com,
        jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
        lionel.g.landwerlin@intel.com, rodrigo.vivi@intel.com,
        tejaskumarx.surendrakumar.upadhyay@intel.com,
        tvrtko.ursulin@intel.com, venkata.s.dhanalakota@intel.com
Cc:     intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20201215144101.1878719-1-trix@redhat.com>
 <160805599050.14591.5854311082825914383@build.alporthouse.com>
From:   Tom Rix <trix@redhat.com>
Message-ID: <12579dc7-603e-2fbe-85c0-0a4110b8992a@redhat.com>
Date:   Tue, 15 Dec 2020 11:00:06 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <160805599050.14591.5854311082825914383@build.alporthouse.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 12/15/20 10:13 AM, Chris Wilson wrote:
> Quoting trix@redhat.com (2020-12-15 14:41:01)
>> From: Tom Rix <trix@redhat.com>
>>
>> See Documentation/core-api/printk-formats.rst.
>> h should no longer be used in the format specifier for printk.
> It's understood by format_decode().
> * 'h', 'l', or 'L' for integer fields
>
> At least reference commit cbacb5ab0aa0 ("docs: printk-formats: Stop
> encouraging use of unnecessary %h[xudi] and %hh[xudi]") as to why the
> printk-formats.rst was altered so we know the code is merely in bad
> taste and not using undefined behaviour of printk.

Ok, i will fix this after the first run of patches.

Tom

> -Chris
>