Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751216AbWIDIsi (ORCPT ); Mon, 4 Sep 2006 04:48:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751211AbWIDIsh (ORCPT ); Mon, 4 Sep 2006 04:48:37 -0400 Received: from rhun.apana.org.au ([64.62.148.172]:58375 "EHLO arnor.apana.org.au") by vger.kernel.org with ESMTP id S1751200AbWIDIsg (ORCPT ); Mon, 4 Sep 2006 04:48:36 -0400 Date: Mon, 4 Sep 2006 18:48:19 +1000 To: Alexey Kuznetsov Cc: "David S. Miller" , Krzysztof Halasa , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: 2.6.18-rc5 with GRE, iptables and Speedtouch ADSL, PPP over ATM Message-ID: <20060904084819.GA27121@gondor.apana.org.au> References: <20060903111507.GA12580@gondor.apana.org.au> <20060904084414.GA19793@ms2.inr.ac.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060904084414.GA19793@ms2.inr.ac.ru> User-Agent: Mutt/1.5.9i From: Herbert Xu Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1109 Lines: 29 On Mon, Sep 04, 2006 at 12:44:14PM +0400, Alexey Kuznetsov wrote: > > Seems, it serializes mod_timer and timer handler to keep timer > in predictable state. Maybe, this is not necessary. A priori, it is required. > > Note that in dev_watchdog_down() queue_lock is released before > taking xmit_lock. Probably, this is the thing which was supposed > to be done in dev_watchdog_up() too. Right, in that case this should definitely be unncessary because both dev_watchdog_up and dev_watchdog_up are called under RTNL. The function __dev_watchdog_up could possibly be dodgy though but that's a different story. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- VGER BF report: H 3.52484e-12 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/