Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201215132024.13356-1-broonie@kernel.org>
In-Reply-To: <20201215132024.13356-1-broonie@kernel.org>
From:   Jagan Teki <jagan@amarulasolutions.com>
Date:   Wed, 16 Dec 2020 01:49:58 +0530
Message-ID: <CAMty3ZDBWAJG3cPYnYtZY4ReOEO6iF5gscs+BLJEQ5WftawmQw@mail.gmail.com>
Subject: Re: [PATCH] regulator: pf8x00: Use specific compatible strings for devices
To:     Mark Brown <broonie@kernel.org>
Cc:     Adrien Grassein <adrien.grassein@gmail.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Dec 15, 2020 at 6:50 PM Mark Brown <broonie@kernel.org> wrote:
>
> The pf8x00 driver supports three devices, the DT compatible strings
> and I2C IDs should enumerate these specifically rather than using a
> wildcard so that we don't collide with anything incompatible in the
> same ID range in the future and so that we can handle any software
> visible differences between the variants we find.

Thanks for the patch.

>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  .../bindings/regulator/nxp,pf8x00-regulator.yaml          | 6 ++++--
>  drivers/regulator/pf8x00-regulator.c                      | 8 ++++++--

I think the bindings patch would be separate? otherwise,

Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>