Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 15 Dec 2020 23:58:32 +0100
From:   Daniel Lezcano <daniel.lezcano@linaro.org>
To:     Thara Gopinath <thara.gopinath@linaro.org>
Cc:     rui.zhang@intel.com, amitk@kernel.org,
        linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/4] thermal/core: Precompute the jiffies
Message-ID: <20201215225832.GB3581@linaro.org>
References: <20201202120657.1969-1-daniel.lezcano@linaro.org>
 <20201202120657.1969-2-daniel.lezcano@linaro.org>
 <1c909a38-1777-556d-fe87-29394a1b1d56@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1c909a38-1777-556d-fe87-29394a1b1d56@linaro.org>
Precedence: bulk

On Tue, Dec 15, 2020 at 09:38:06AM -0500, Thara Gopinath wrote:
> Hi Daniel,
> 
> On 12/2/20 7:06 AM, Daniel Lezcano wrote:
> > The delays are stored in ms units and when the polling function is
> > called this delay is converted into jiffies at each call.
> > 
> > Instead of doing the conversion again and again, compute the jiffies
> > at init time and use the value directly when setting the polling.
> 
> A generic comment. You can avoid patch 1 of this series and directly
> have patch 2 , right? There is no need to rename polling_delay/passive_delay
> to *_delay_ms and then remove it again?

Yes, I can simplify that.

> > 
> > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> > ---

[ ... ]

> > +static inline void thermal_zone_set_polling_delay(
> > +	struct thermal_zone_device *tz, int delay_ms)
> > +{
> > +	tz->polling_delay_ms = delay_ms;
> > +	tz->polling_delay_jiffies = msecs_to_jiffies(delay_ms);
> > +	if (delay_ms > 1000)
> > +		tz->polling_delay_jiffies = round_jiffies(tz->polling_delay_jiffies);
> > +}
> 
> How about one function instead?
> static inline void thermal_zone_set_delay_jiffies(int *delay_jiffes, int
> delay_ms)
> {
> 	*delay_jiffies = msecs_to_jiffies(delay_ms);
> 	if (delay_ms > 1000)
> 		*delay_jiffies = round_jiffies(*delay_jiffies);
> }
> 
> And then calling thermal_zone_set_delay_jiffies(&tz->passive_delay_jiffies,
> passive_delay)..
 
Yes, agree. I'll do this change.

Thanks for the review

  -- Daniel

-- 

 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog