Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp894937pxu; Wed, 16 Dec 2020 18:26:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJyYiIPsdb1lTwqwZDViX6Mw63zfxX7DiVgZElxt/P4JxCqHzOXdPPP/+KxTOuPAtaxvdQAC X-Received: by 2002:a50:bb44:: with SMTP id y62mr36499814ede.103.1608171964627; Wed, 16 Dec 2020 18:26:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608171964; cv=none; d=google.com; s=arc-20160816; b=Rz8XaOlJ775QSVTGjC6D1D4CAxSlINBkVUIJnFNVfdPniugL4y1XBFJtcx3SQJl9PT M8y9E8j3EiUDiLgOs93k5hdZRVtHVpx54irSyFcQSZjQFsXhM3KZLeejoEQfoCBh4BeN hI3mj/2DveMp05IiKkv8MnBokxwRmlhKSLA1sD0dooZR5ZPScjve/fx3rdqueExh3p6g ciyyfvZp5dzsXqpug/jy+JEVwiBUfNWuDUwgyrtkHboJLdHVVAFVA7TF1V4nQJTuLmwt HPoVsgJ+XntrCvCjwQWesdt3v2chh/mwiWkpQSjcoVa0gknmd4W8jut6Eix2YkarOIs5 6+uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=8uHs/UhveALE70R5Z9Kg2unr079LnQrGmTT2HTgImw8=; b=tnI5lMmX9cc5s9tt2OS5P0vNQYpcRW2xcxXjRAS4iKZ6qAW1/pDRqoWhzyqrmBR87n wWEgiy7nRxHwSk/i72UUNi9fvhiuXTd7eR1QC2sr0y1fDAUajU7O3J+imglSrOgGwUO8 yEZkJI82lEs20xrZC/WhEpV4pTnXdiJ6D7le/zulDd70Ui6WuCmB6m9e7q4EJnLS2s7f 7NAijQ7rQY9fmGgUBPTr3EGeQ111i3710CzW4wQqc/bWSztSfxyLnilkF7AGl88Ow8qY 0+J2JbeLNlHSXUG3x+AtIZ36vvRYduqS8LUh9SO62inB6SE5R2OK2OUM/F8selb01uLk MFAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=FifsAiB3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y15si1853752ejp.228.2020.12.16.18.25.42; Wed, 16 Dec 2020 18:26:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=FifsAiB3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727262AbgLQCX5 (ORCPT + 99 others); Wed, 16 Dec 2020 21:23:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727090AbgLQCX5 (ORCPT ); Wed, 16 Dec 2020 21:23:57 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B62BC06179C for ; Wed, 16 Dec 2020 18:23:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8uHs/UhveALE70R5Z9Kg2unr079LnQrGmTT2HTgImw8=; b=FifsAiB3tLiNJPag7q9n8RFM5/ pk9gX7tAuQJSETnc6fT6mFCRtrmN3ucHavM6Xn8K8jvyvhnvox/5tUNajqntYzSL73VRjnutHSRRk dg0m/5QJ/CJcdVCoEACAjAX3L9w7x9cRok3++Zkax/N3DQyOXMOpcTvBbBge9izlvqW24uQ44vqfr vpuHGZ3P7SpVuUwaPvWYf7AeNS8XyAOn56x/x3kdr+t425vgJ7xisdFmaqVU2J/TG5SNkqDKR6v8/ jx9NgNK9WY7uHm/XaZ0DfFvzk8y0+YmPCU6UFT3tq1q1fdx+IDleU30BRZ+07RmdqXv6xHstJJrwM WhSosgcw==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpiwc-0007Ne-NI; Thu, 17 Dec 2020 02:23:06 +0000 Date: Thu, 17 Dec 2020 02:23:06 +0000 From: Matthew Wilcox To: Xiangyang Yu Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/filemap: Fix warning: no previous prototype Message-ID: <20201217022306.GB15600@casper.infradead.org> References: <20201217020311.491799-1-yuxiangyang4@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201217020311.491799-1-yuxiangyang4@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 17, 2020 at 10:03:11AM +0800, Xiangyang Yu wrote: > Fixed the warning when building with warnings enabled (W=1), > This function is only used in filemap.c, so mark this function > with 'static'. Good grief, no. Look at the git history before proposing a patch.