Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Robin Gong <yibin.gong@nxp.com>
To:     perex@perex.cz, tiwai@suse.com, akpm@linux-foundation.org,
        xiang@kernel.org, pierre-louis.bossart@linux.intel.com,
        gustavoars@kernel.org, shengjiu.wang@nxp.com
Cc:     alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: [PATCH v1 ] ALSA: core: memalloc: add page alignment for iram
Date:   Fri, 18 Dec 2020 00:15:47 +0800
Message-Id: <1608221747-3474-1-git-send-email-yibin.gong@nxp.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from robin-OptiPlex-790.ap.freescale.net (119.31.174.66) by SG2PR02CA0004.apcprd02.prod.outlook.com (2603:1096:3:17::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3654.12 via Frontend Transport; Thu, 17 Dec 2020 07:59:59 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: bcdca302-a3c5-4ed3-1bb3-08d8a261c278
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3549:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <VI1PR0402MB3549B4067E546C4BEC61BF3E89C40@VI1PR0402MB3549.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4303;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: oxBOE49abwn1qigOjMY4nWRCp6G726ZQMHyGGYlWe9vx9qt8e76FGoI2g4zq2z0IJd3v/nkEuUenR67es6iY+uckiHe5uyPmWKUtlot6Cs+k+hj6hlkePMOnjkjKjroPrfaO3GX1GiJ+a4SeGuHFOhlIUPm4Msy0XVb5ZOQIxjCCkPH12fcvPTOZi/6r/57s2sUlr90HzHQw130vue7vxCsnV3szAAvyaAxtFdg52oSOeDAdXwcDJHbsf+CqAajkCIU52fxpfrmYav12J2Idz7Rpca60mID5MSAZJSsBsYFMDmUOYR4+91o97ox3nWgUM23h4dYSgOv798PlycygRQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6638.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(39860400002)(396003)(376002)(136003)(6512007)(316002)(956004)(66476007)(478600001)(6486002)(36756003)(86362001)(6666004)(6636002)(52116002)(8936002)(186003)(4326008)(66946007)(83380400001)(2616005)(16526019)(26005)(4744005)(2906002)(8676002)(5660300002)(66556008)(6506007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?d6kRqk39AqeaA9nRnlDXo7iq7Cjhb3mrGV+HUYVUfvmfKgUMsYEb3csfNDGK?=
 =?us-ascii?Q?9jYrKPfDog7Rjvfl8MaIUNGmSuJ0Htu1lCBSsuvFpV98SJCc6QZ5FiOJGOIm?=
 =?us-ascii?Q?OzlQGa3Edl26ssojdyf14iBgSYzC5OlxNjjV4dOOizhr/FwwhThrqnQEBghN?=
 =?us-ascii?Q?u2UzhE2jPm5DiPRsLG4+F91E1ik115P5+O1c/eBL6+W/JeBBouZi+AV76yX2?=
 =?us-ascii?Q?PY8ZNKBXUrrV3/FAZHUhQT2zm6Q2HutToHki66XQ5PKkl+1Y2VrOH21anOd6?=
 =?us-ascii?Q?rBKPkGDbUV3THCI9JmrCg9n0W2H5qHjCaXYIghjswFEx9bxP/qkfSrQAhehQ?=
 =?us-ascii?Q?1QOTvi3hfT48XaP9qR9sj1/Te4W0L5jH0nzfPr9B1RssxCqXj8VWUKW+g0CH?=
 =?us-ascii?Q?azEA99Fa4XvXN3rbBDQw64XihrPyFr6sN6a6nGF38kuPn3zwy04dfd+3KoXc?=
 =?us-ascii?Q?bEuEcyfwLE756EfqzQC4sIrV6LU18zBGt4SnUYwvxTFSQG/X2204Hr9Ao3Qv?=
 =?us-ascii?Q?Qtno423TEZbi3YWoXAzWSzb7y553qLHDfSZuEjqmeLS1FVMI4Ytfb7gQd1FU?=
 =?us-ascii?Q?6MCujNSSKMXYgUYXaS1bFj/pWMnEPh+9kAPfTLVMY1YPsHJesGEVivobBKcw?=
 =?us-ascii?Q?OhymYwFcnWd2HUSLmBvKdpXclxnAN2eIXYQy37mYPxJlFS6FpoQ3P8ZgRL8N?=
 =?us-ascii?Q?cPKgjFTXx6QRVPYsPdoZgglHIFlEI+YnFC8wAN4tQC2KI68+PD4TG/Eo5VSJ?=
 =?us-ascii?Q?I0Nd8Wr/u6WvvtM944N9XPLdzhTIPwhsWUMT6psFIslmv2qveupav7DthYlP?=
 =?us-ascii?Q?C1BPS4cceyrrR/JwIb3iJ/mZsxCKqf8dBhuHN7lBIikXSkjKfo9LiqgOONvn?=
 =?us-ascii?Q?dfjHcKx8FNVNIh+UF8QzBvZeho/Rys2QoFzacShhji6dwNKHzO8l/yoilgdK?=
 =?us-ascii?Q?QEEB81UgxAelgb8ytmTrTZZcWD9S27RuoDAwanEgvCmwuiVI1VhCimzlDuXZ?=
 =?us-ascii?Q?wJyv?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6638.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2020 08:00:03.0104
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-Network-Message-Id: bcdca302-a3c5-4ed3-1bb3-08d8a261c278
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rYccN9F+yDGyi3QGBd1QKhYCXx9xaw8uC7wwyJ97eci0wl+ImjM9VB8KNqipatu13n2ntmtrFQ8KX04Cnn1wjw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3549
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Since mmap for userspace is based on page alignment, add page alignment
for iram alloc from pool, otherwise, some good data located in the same
page of dmab->area maybe touched wrongly by userspace like pulseaudio.

Signed-off-by: Robin Gong <yibin.gong@nxp.com>
---
 sound/core/memalloc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/core/memalloc.c b/sound/core/memalloc.c
index 0aeeb62..0f33516 100644
--- a/sound/core/memalloc.c
+++ b/sound/core/memalloc.c
@@ -77,7 +77,8 @@ static void snd_malloc_dev_iram(struct snd_dma_buffer *dmab, size_t size)
 	/* Assign the pool into private_data field */
 	dmab->private_data = pool;
 
-	dmab->area = gen_pool_dma_alloc(pool, size, &dmab->addr);
+	dmab->area = gen_pool_dma_alloc_align(pool, size, &dmab->addr,
+					PAGE_SIZE);
 }
 
 /**
-- 
2.7.4