Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <202012171008.TsSBPhT7-lkp@intel.com>
In-Reply-To: <202012171008.TsSBPhT7-lkp@intel.com>
From:   Sergio Paracuellos <sergio.paracuellos@gmail.com>
Date:   Thu, 17 Dec 2020 09:33:43 +0100
Message-ID: <CAMhs-H_nHshVFvBvi1KmVEPTxX7bpNpp0jL9+UY9c9z-iqf5gQ@mail.gmail.com>
Subject: Re: drivers/pinctrl/ralink/pinctrl-rt2880.c:365:12: warning: no
 previous prototype for 'rt2880_pinmux_init'
To:     kernel test robot <lkp@intel.com>
Cc:     kbuild-all@lists.01.org,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linus Walleij <linus.walleij@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Thu, Dec 17, 2020 at 3:17 AM kernel test robot <lkp@intel.com> wrote:
>
> Hi Sergio,
>
> First bad commit (maybe != root cause):
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   accefff5b547a9a1d959c7e76ad539bf2480e78b
> commit: 518b466a21ad7fa1e338fa4ed9d180ef439d3bc0 pinctrl: ralink: add a pinctrl driver for the rt2880 family
> date:   9 days ago
> config: mips-randconfig-r025-20201217 (attached as .config)
> compiler: mipsel-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=518b466a21ad7fa1e338fa4ed9d180ef439d3bc0
>         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>         git fetch --no-tags linus master
>         git checkout 518b466a21ad7fa1e338fa4ed9d180ef439d3bc0
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/pinctrl/ralink/pinctrl-rt2880.c:365:12: warning: no previous prototype for 'rt2880_pinmux_init' [-Wmissing-prototypes]
>      365 | int __init rt2880_pinmux_init(void)
>          |            ^~~~~~~~~~~~~~~~~~
>
>
> vim +/rt2880_pinmux_init +365 drivers/pinctrl/ralink/pinctrl-rt2880.c
>
> 0317d60de869786 drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c John Crispin       2018-03-15  364
> 1d2d116a93f0e9b drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c Sergio Paracuellos 2018-07-09 @365  int __init rt2880_pinmux_init(void)
> 1d2d116a93f0e9b drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c Sergio Paracuellos 2018-07-09  366  {
> 1d2d116a93f0e9b drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c Sergio Paracuellos 2018-07-09  367      return platform_driver_register(&rt2880_pinmux_driver);
> 1d2d116a93f0e9b drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c Sergio Paracuellos 2018-07-09  368  }
> 1d2d116a93f0e9b drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c Sergio Paracuellos 2018-07-09  369

Yes, there is no such prototype for this global. This should be
declared 'static' instead as it is only used from this driver code
using 'core_initcall_sync'.
Will send a patch with this change. CC'ed Linus because this driver is
in his subsystem now.

>
> :::::: The code at line 365 was first introduced by commit
> :::::: 1d2d116a93f0e9bf0bca72da76a96edef8a1d36d Revert "staging: mt7621-pinctrl: replace core_initcall_sync with builtin_platform_driver"

Not really, it was there from the very beginning but I made a change
to try to use this in a later stage in the boot process without
success. Thus, this commit is the revert for that one.

>
> :::::: TO: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> :::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Best regards,
    Sergio Paracuellos