Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 17 Dec 2020 12:06:47 +0100
Message-ID: <s5hmtyclmig.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Lars-Peter Clausen <lars@metafoo.de>
Cc:     alsa-devel@alsa-project.org, gustavoars@kernel.org,
        linux-kernel@vger.kernel.org, shengjiu.wang@nxp.com,
        pierre-louis.bossart@linux.intel.com, tiwai@suse.com,
        xiang@kernel.org, Robin Gong <yibin.gong@nxp.com>,
        akpm@linux-foundation.org
Subject: Re: [PATCH v1 ] ALSA: core: memalloc: add page alignment for iram
In-Reply-To: <70074f62-954a-9b40-ab4a-cb438925060c@metafoo.de>
References: <1608221747-3474-1-git-send-email-yibin.gong@nxp.com>
        <05c824e5-0c33-4182-26fa-b116a42b10d6@metafoo.de>
        <s5h5z50n4dd.wl-tiwai@suse.de>
        <70074f62-954a-9b40-ab4a-cb438925060c@metafoo.de>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 17 Dec 2020 11:59:23 +0100,
Lars-Peter Clausen wrote:
> 
> On 12/17/20 10:55 AM, Takashi Iwai wrote:
> > On Thu, 17 Dec 2020 10:43:45 +0100,
> > Lars-Peter Clausen wrote:
> >> On 12/17/20 5:15 PM, Robin Gong wrote:
> >>> Since mmap for userspace is based on page alignment, add page alignment
> >>> for iram alloc from pool, otherwise, some good data located in the same
> >>> page of dmab->area maybe touched wrongly by userspace like pulseaudio.
> >>>
> >> I wonder, do we also have to align size to be a multiple of PAGE_SIZE
> >> to avoid leaking unrelated data?
> > Hm, a good question.  Basically the PCM buffer size itself shouldn't
> > be influenced by that (i.e. no hw-constraint or such is needed), but
> > the padding should be cleared indeed.  I somehow left those to the
> > allocator side, but maybe it's safer to clear the whole buffer in
> > sound/core/memalloc.c commonly.
> 
> What I meant was that most of the APIs that we use to allocate memory
> work on a PAGE_SIZE granularity. I.e. if you request a buffer that
> where the size is not a multiple of PAGE_SIZE internally they will
> still allocate a buffer that is a multiple of PAGE_SIZE and mark the
> unused bytes as reserved.
> 
> But I believe that is not the case gen_pool_dma_alloc(). It will
> happily allocate those extra bytes to some other allocation request.
> 
> That we need to zero out the reserved bytes even for those other APIs
> is a very good additional point!
> 
> I looked at this a few years ago and I'm pretty sure that we cleared
> out the allocated area, but I can't find that anymore in the current
> code. Which is not so great I guess.

IIRC, we used GFP_ZERO in the past for the normal page allocations,
but this was dropped as it's no longer supported or so.

Also, we clear out the PCM buffer in hw_params call, but this is for
the requested size, not the actual allocated size, hence the padding
bytes will remain uncleared.

So I believe it's safer to add an extra memset() like my test patch.


Takashi