Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1157273pxu; Thu, 17 Dec 2020 03:43:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJw7I4c+WTaBX1qN3X2BJvoKb0dNyRVvv0GVkx/z4KCFjuM/6twO4o64ybFNJg51cU2ghvGT X-Received: by 2002:a17:906:1ed6:: with SMTP id m22mr18243080ejj.231.1608205399927; Thu, 17 Dec 2020 03:43:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608205399; cv=none; d=google.com; s=arc-20160816; b=aearXvzqYD48x7q+3BRRYUbxxgtk+djT0dJpY8RtkcxL+GJqr9NgteywdiW5Z+Lpli 5T5aC+O9/sHC0t01Rj1bEpb51nNWTkXi6qTsJWKrBpANp9MQh/mKA2JOxdFYHvHyEvI3 ZmzdExPhdOMFRFUxA94OUKJsjAzf9wkeYXRzB4YXk8nqQ5qaFDvrbisGx/q4QinNRRjs 9QITslHpMa5HLoBJU97dS112zT0oKMkr/8eksVketJx99Xi0nRRw5rZrqNoV6J7CxTuq DvWHtmgPv6YzhOnblf97RZPlSPwp4GSYTV5NC53yU6FyPro1B6psA5CbU7QmkPrlz33L hDYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:reply-to:from:subject :message-id; bh=KAIkvqI4ZOy6Pge+Xctt4YV1U0gqyi7c0LfIrQbX8RE=; b=aGkrPa4I6y6c7em9fOTANJ1zl4ak5+FtwtS7kz8e1oLMztIVukA0AaG40LNhqF7YA0 JbAbnymsQkgeInas3X80697NWTspt/O+18p9EHVbHLoqsQjZ7UJVhFqP8EFETIjCaupZ kpG5LFBJdvxraYUcBL3l6Kv+jFz5FwPMvgtL/Mw/cr+BdyroRB/qAGEvsrXSa/FDbJ5r jFWNsgLzJ0gDclupPaujZl+L7zV4ZRHtATOgK7XjyB8Ud4Tvbf65DE+7e75c656CHKLr AoHvadq8etumhxhd9RChjDSMLkt3DjBtcCNrv+N5A1NvjBXd+EUouMgZ6l4QiTHTqk23 xLpw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h14si2645254eje.368.2020.12.17.03.42.57; Thu, 17 Dec 2020 03:43:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727936AbgLQLlC (ORCPT + 99 others); Thu, 17 Dec 2020 06:41:02 -0500 Received: from mx2.suse.de ([195.135.220.15]:45242 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726773AbgLQLlB (ORCPT ); Thu, 17 Dec 2020 06:41:01 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 527A2AC7B; Thu, 17 Dec 2020 11:40:20 +0000 (UTC) Message-ID: Subject: Re: [PATCH 1/3] cifs: Delete a stray unlock in cifs_swn_reconnect() From: Samuel Cabrero Reply-To: scabrero@suse.com To: Dan Carpenter , Steve French Cc: Aurelien Aptel , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Date: Thu, 17 Dec 2020 12:40:18 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-12-17 at 14:01 +0300, Dan Carpenter wrote: > The unlock is done in the caller, this is a stray which leads to a > double unlock bug. > Indeed. Reviewed-by: Samuel Cabrero -- Samuel Cabrero / SUSE Labs Samba Team GPG: D7D6 E259 F91C F0B3 2E61 1239 3655 6EC9 7051 0856 scabrero@suse.com scabrero@suse.de