Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 17 Dec 2020 13:59:22 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc:     Eric Anholt <eric@anholt.net>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Daniel Vetter <daniel.vetter@intel.com>,
        David Airlie <airlied@linux.ie>,
        Jason Cooper <jason@lakedaemon.net>,
        bcm-kernel-feedback-list@broadcom.com,
        linux-arm-kernel@lists.infradead.org,
        Marc Zyngier <maz@kernel.org>, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Dave Stevenson <dave.stevenson@raspberrypi.com>,
        linux-rpi-kernel@lists.infradead.org,
        dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 00/15] drm/vc4: hdmi: Add CEC support for the BCM2711
Message-ID: <20201217125922.bx3wx3dwcl6lojre@gilmour>
References: <20201210134648.272857-1-maxime@cerno.tech>
 <23bdb67a-fb55-42d4-9130-ade1b0396768@xs4all.nl>
 <20201217104946.srurfmuphqzz4c4w@gilmour>
 <cc3e0adf-ba44-7593-40ec-3d2c1efcba02@xs4all.nl>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="4u5pz2ddgui6hzza"
Content-Disposition: inline
In-Reply-To: <cc3e0adf-ba44-7593-40ec-3d2c1efcba02@xs4all.nl>
Precedence: bulk


--4u5pz2ddgui6hzza
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Hans,

On Thu, Dec 17, 2020 at 11:53:42AM +0100, Hans Verkuil wrote:
> On 17/12/2020 11:49, Maxime Ripard wrote:
> > Hi Hans,
> >=20
> > On Wed, Dec 16, 2020 at 01:35:43PM +0100, Hans Verkuil wrote:
> >> Hi Maxime,
> >>
> >> On 10/12/2020 14:46, Maxime Ripard wrote:
> >>> Hi,
> >>>
> >>> Here's a series introducing the CEC support for the BCM2711 found on =
the
> >>> RaspberryPi4.
> >>>
> >>> The BCM2711 HDMI controller uses a similar layout for the CEC registe=
rs, the
> >>> main difference being that the interrupt handling part is now shared =
between
> >>> both HDMI controllers.
> >>>
> >>> This series is mainly about fixing a couple of bugs, reworking the dr=
iver to
> >>> support having two different interrupts, one for each direction, prov=
ided by an
> >>> external irqchip, and enables the irqchip driver for the controller w=
e have.
> >>>
> >>> This has been tested on an RPi3 and RPi4, but requires the latest fir=
mware.
> >>> It's is based on the 10 and 12 bpc series.
> >>
> >> This series looks good to me. Before I give my Acked-by for this serie=
s, can you
> >> confirm that it is possible to transmit the Image View On message on b=
oth outputs
> >> of the RPi4 when the HPD is low?
> >>
> >> See section "CEC Without HPD" in https://hverkuil.home.xs4all.nl/cec-s=
tatus.txt
> >> on how to test this with a Pulse-Eight device.
> >>
> >> This should work.
> >=20
> > This is the output on the RPi4:
> >=20
> > # cec-ctl --playback
> > Driver Info:
> > 	Driver Name                : vc4_hdmi
> > 	Adapter Name               : vc4
> > 	Capabilities               : 0x0000010e
> > 		Logical Addresses
> > 		Transmit
> > 		Passthrough
> > 	Driver version             : 5.10.0
> > 	Available Logical Addresses: 1
> > 	Physical Address           : f.f.f.f
> > 	Logical Address Mask       : 0x0000
> > 	CEC Version                : 2.0
> > 	Vendor ID                  : 0x000c03 (HDMI)
> > 	OSD Name                   : Playback
> > 	Logical Addresses          : 1 (Allow RC Passthrough)
> >=20
> > 	  Logical Address          : Not Allocated
> > 	    Primary Device Type    : Playback
> > 	    Logical Address Type   : Playback
> > 	    All Device Types       : Playback
> > 	    RC TV Profile          : None
> > 	    Device Features        :
> > 		None
> >=20
> > # cec-ctl -t0 --image-view-on
> > Driver Info:
> > 	Driver Name                : vc4_hdmi
> > 	Adapter Name               : vc4
> > 	Capabilities               : 0x0000010e
> > 		Logical Addresses
> > 		Transmit
> > 		Passthrough
> > 	Driver version             : 5.10.0
> > 	Available Logical Addresses: 1
> > 	Physical Address           : f.f.f.f
> > 	Logical Address Mask       : 0x0000
> > 	CEC Version                : 2.0
> > 	Vendor ID                  : 0x000c03 (HDMI)
> > 	OSD Name                   : Playback
> > 	Logical Addresses          : 1 (Allow RC Passthrough)
> >=20
> > 	  Logical Address          : Not Allocated
> > 	    Primary Device Type    : Playback
> > 	    Logical Address Type   : Playback
> > 	    All Device Types       : Playback
> > 	    RC TV Profile          : None
> > 	    Device Features        :
> > 		None
> >=20
> >=20
> > Transmit from Unregistered to TV (15 to 0):
> > CEC_MSG_IMAGE_VIEW_ON (0x04)
> > 	Sequence: 1 Tx Timestamp: 77.631s
> >=20
> >=20
> > And this is the output on my desktop with the Pulse-Eight:
> > $ sudo cec-ctl -p0.0.0.0 --tv
> > Driver Info:
> > 	Driver Name                : pulse8-cec
> > 	Adapter Name               : serio0
> > 	Capabilities               : 0x0000003f
> > 		Physical Address
> > 		Logical Addresses
> > 		Transmit
> > 		Passthrough
> > 		Remote Control Support
> > 		Monitor All
> > 	Driver version             : 5.9.8
> > 	Available Logical Addresses: 1
> > 	Connector Info             : None
> > 	Physical Address           : 0.0.0.0
> > 	Logical Address Mask       : 0x0001
> > 	CEC Version                : 2.0
> > 	Vendor ID                  : 0x000c03 (HDMI)
> > 	OSD Name                   : 'TV  '
> > 	Logical Addresses          : 1 (Allow RC Passthrough)
> >=20
> > 	  Logical Address          : 0 (TV)
> > 	    Primary Device Type    : TV
> > 	    Logical Address Type   : TV
> > 	    All Device Types       : TV
> > 	    RC TV Profile          : None
> > 	    Device Features        :
> > 		None
> >=20
> > $ sudo cec-ctl -M
> > Driver Info:
> > 	Driver Name                : pulse8-cec
> > 	Adapter Name               : serio0
> > 	Capabilities               : 0x0000003f
> > 		Physical Address
> > 		Logical Addresses
> > 		Transmit
> > 		Passthrough
> > 		Remote Control Support
> > 		Monitor All
> > 	Driver version             : 5.9.8
> > 	Available Logical Addresses: 1
> > 	Connector Info             : None
> > 	Physical Address           : 0.0.0.0
> > 	Logical Address Mask       : 0x0001
> > 	CEC Version                : 2.0
> > 	Vendor ID                  : 0x000c03 (HDMI)
> > 	OSD Name                   : 'TV  '
> > 	Logical Addresses          : 1 (Allow RC Passthrough)
> >=20
> > 	  Logical Address          : 0 (TV)
> > 	    Primary Device Type    : TV
> > 	    Logical Address Type   : TV
> > 	    All Device Types       : TV
> > 	    RC TV Profile          : None
> > 	    Device Features        :
> > 		None
> >=20
> >=20
> >=20
> > Initial Event: State Change: PA: 0.0.0.0, LA mask: 0x0001, Conn Info: no
> > Received from Unregistered to TV (15 to 0): IMAGE_VIEW_ON (0x04)
> >=20
> > So it looks like it's working as expected?
>=20
> Yes, it looks good. Make sure you test this for both outputs of the RPi4.

It's a good thing you asked, I don't appear to get CEC interrupts from
HDMI1. I'll fix it and send another version (probably not before the end
of december though).

> If it works for both, then you can add my
>=20
> Acked-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
>=20
> for this series.
>=20
> Very nice work, thank you for doing this!

Thanks!

I'll hold your a-b until the next version though, fixing hdmi1 might
change a few things.

Maxime

--4u5pz2ddgui6hzza
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX9tWKgAKCRDj7w1vZxhR
xVdvAQDHuSRkKxYlgj3+2EqQTksC/VHwJz4gK9OkV9xSfhloJQEA1zz9IR3RFXAN
SWKYX8zarHyj+PLw8tW6ddst/1rk+A0=
=49ci
-----END PGP SIGNATURE-----

--4u5pz2ddgui6hzza--