Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 17 Dec 2020 14:36:44 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Dmitry Osipenko <digetx@gmail.com>
Cc:     Jonathan Hunter <jonathanh@nvidia.com>,
        Peter Chen <Peter.Chen@nxp.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        Felipe Balbi <balbi@kernel.org>,
        Matt Merhar <mattmerhar@protonmail.com>,
        Nicolas Chauvet <kwizart@gmail.com>,
        Peter Geis <pgwipeout@gmail.com>,
        Ion Agorria <ion@agorria.com>, linux-tegra@vger.kernel.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/8] usb: chipidea: tegra: Rename UDC to USB
Message-ID: <X9te7ObUU1Fcy2ut@ulmo>
References: <20201217094007.19336-1-digetx@gmail.com>
 <20201217094007.19336-5-digetx@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="2QB7O1hFTgaD5tHU"
Content-Disposition: inline
In-Reply-To: <20201217094007.19336-5-digetx@gmail.com>
User-Agent: Mutt/2.0.3 (a51f058f) (2020-12-04)
Precedence: bulk


--2QB7O1hFTgaD5tHU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 17, 2020 at 12:40:03PM +0300, Dmitry Osipenko wrote:
> Rename all occurrences in the code from "udc" to "usb" and change the
> Kconfig entry in order to show that this driver supports USB modes other
> than device-only mode. The follow up patch will add host-mode support and
> it will be cleaner to perform the renaming separately, i.e. in this patch.
>=20
> Tested-by: Matt Merhar <mattmerhar@protonmail.com>
> Tested-by: Nicolas Chauvet <kwizart@gmail.com>
> Tested-by: Peter Geis <pgwipeout@gmail.com>
> Tested-by: Ion Agorria <ion@agorria.com>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>  drivers/usb/chipidea/Kconfig         |  2 +-
>  drivers/usb/chipidea/ci_hdrc_tegra.c | 78 ++++++++++++++--------------
>  2 files changed, 40 insertions(+), 40 deletions(-)
>=20
> diff --git a/drivers/usb/chipidea/Kconfig b/drivers/usb/chipidea/Kconfig
> index 8bafcfc6080d..8685ead6ccc7 100644
> --- a/drivers/usb/chipidea/Kconfig
> +++ b/drivers/usb/chipidea/Kconfig
> @@ -53,7 +53,7 @@ config USB_CHIPIDEA_GENERIC
>  	default USB_CHIPIDEA
> =20
>  config USB_CHIPIDEA_TEGRA
> -	tristate "Enable Tegra UDC glue driver" if EMBEDDED
> +	tristate "Enable Tegra USB glue driver" if EMBEDDED
>  	depends on OF
>  	depends on USB_CHIPIDEA_UDC
>  	default USB_CHIPIDEA
> diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c b/drivers/usb/chipidea/=
ci_hdrc_tegra.c
> index 10eaaba2a3f0..d8efa80aa1c2 100644
> --- a/drivers/usb/chipidea/ci_hdrc_tegra.c
> +++ b/drivers/usb/chipidea/ci_hdrc_tegra.c
> @@ -12,7 +12,7 @@
> =20
>  #include "ci.h"
> =20
> -struct tegra_udc {
> +struct tegra_usb {
>  	struct ci_hdrc_platform_data data;
>  	struct platform_device *dev;
> =20
> @@ -20,15 +20,15 @@ struct tegra_udc {
>  	struct clk *clk;
>  };
> =20
> -struct tegra_udc_soc_info {
> +struct tegra_usb_soc_info {
>  	unsigned long flags;
>  };
> =20
> -static const struct tegra_udc_soc_info tegra_udc_soc_info =3D {
> +static const struct tegra_usb_soc_info tegra_udc_soc_info =3D {
>  	.flags =3D CI_HDRC_REQUIRES_ALIGNED_DMA,
>  };
> =20
> -static const struct of_device_id tegra_udc_of_match[] =3D {
> +static const struct of_device_id tegra_usb_of_match[] =3D {
>  	{
>  		.compatible =3D "nvidia,tegra20-udc",

Do we perhaps also want to add a new tegra20-usb compatible string here
and deprecate the old one since this now no longer properly describes
the device.

In either case, this looks fine:

Acked-by: Thierry Reding <treding@nvidia.com>

--2QB7O1hFTgaD5tHU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl/bXuwACgkQ3SOs138+
s6FKBQ//TBLMtbsou6bbuudeuQEKvYa0tffjko5YwU5sr/g3gDENC3MRSPt7XqFg
4VUhcMXqJV2GOhmvf12SzEIx4L/pFwU41nvJdI5WQGj1IbvWZI3xvwj/HIJZFvBE
KE5l59EJ6rO8a06fxRBEIADDZ/htTXnC3dLTpT8aNL6Rhs7rGshRwzYnoLjgy8nH
Me9zmlbmfjUUB3wxWMEvzZImI3qB1xrKr3D6v2i/v7wAvese3jGP0mezjOScHpUe
udFeKz3ssmyoUoOkZml4yvGt88AMe+a33R1lXNmdawNoHFWhh5jqCRTCHOnLwc8M
SFmAWMUV84sLcSaZoiBB8uJLdnVWjx3tI3/4+qkPVER2nYCVpjPcxuEKf+uDCQUs
7fWIt43/vxT9ULWLaFs7xVlRcE4gSkAn8wXc+5dOT+VF8DO/XluLCqNZd/TYXe1r
F7ZXJS/neZ+2axQ9mTzBDfOMf1+sA5wRb68ckfhReoTosLrko9OAicWwbkFguVBs
fj7Ivtmn5oiXzrIK0tNDZnFMYM8UiJhe3TUOdGJNp5w5p6q+C7vwLo8282AOtJtZ
fuAdby9e0IDua3I6KUZrMIw341w0LhOs4nZYwNSBf26XSxfZVGUfHR53ZkgiBxSv
7pA62Lx5o/sMqZTxaEuPDUk4Nfs3wFIil5z6CMv+uc1QtOzo9Do=
=7nxN
-----END PGP SIGNATURE-----

--2QB7O1hFTgaD5tHU--