Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 17 Dec 2020 14:41:35 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Dmitry Osipenko <digetx@gmail.com>
Cc:     Jonathan Hunter <jonathanh@nvidia.com>,
        Peter Chen <Peter.Chen@nxp.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        Felipe Balbi <balbi@kernel.org>,
        Matt Merhar <mattmerhar@protonmail.com>,
        Nicolas Chauvet <kwizart@gmail.com>,
        Peter Geis <pgwipeout@gmail.com>,
        Ion Agorria <ion@agorria.com>, linux-tegra@vger.kernel.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/8] usb: chipidea: tegra: Support runtime PM
Message-ID: <X9tgD+KSU1bIvht5@ulmo>
References: <20201217094007.19336-1-digetx@gmail.com>
 <20201217094007.19336-7-digetx@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="n/D9wwuYCvcRgZHH"
Content-Disposition: inline
In-Reply-To: <20201217094007.19336-7-digetx@gmail.com>
User-Agent: Mutt/2.0.3 (a51f058f) (2020-12-04)
Precedence: bulk


--n/D9wwuYCvcRgZHH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 17, 2020 at 12:40:05PM +0300, Dmitry Osipenko wrote:
> Tegra PHY driver now supports waking up controller from a low power mode.
> Enable runtime PM in order to put controller into the LPM during idle.
>=20
> Tested-by: Matt Merhar <mattmerhar@protonmail.com>
> Tested-by: Nicolas Chauvet <kwizart@gmail.com>
> Tested-by: Peter Geis <pgwipeout@gmail.com>
> Tested-by: Ion Agorria <ion@agorria.com>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>  drivers/usb/chipidea/ci_hdrc_tegra.c | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c b/drivers/usb/chipidea/=
ci_hdrc_tegra.c
> index 5fccdeeefc64..655671159511 100644
> --- a/drivers/usb/chipidea/ci_hdrc_tegra.c
> +++ b/drivers/usb/chipidea/ci_hdrc_tegra.c
> @@ -38,21 +38,24 @@ struct tegra_usb_soc_info {
> =20
>  static const struct tegra_usb_soc_info tegra20_ehci_soc_info =3D {
>  	.flags =3D CI_HDRC_REQUIRES_ALIGNED_DMA |
> -		 CI_HDRC_OVERRIDE_PHY_CONTROL,
> +		 CI_HDRC_OVERRIDE_PHY_CONTROL |
> +		 CI_HDRC_SUPPORTS_RUNTIME_PM,
>  	.dr_mode =3D USB_DR_MODE_HOST,
>  	.txfifothresh =3D 10,
>  };
> =20
>  static const struct tegra_usb_soc_info tegra30_ehci_soc_info =3D {
>  	.flags =3D CI_HDRC_REQUIRES_ALIGNED_DMA |
> -		 CI_HDRC_OVERRIDE_PHY_CONTROL,
> +		 CI_HDRC_OVERRIDE_PHY_CONTROL |
> +		 CI_HDRC_SUPPORTS_RUNTIME_PM,
>  	.dr_mode =3D USB_DR_MODE_HOST,
>  	.txfifothresh =3D 16,
>  };
> =20
>  static const struct tegra_usb_soc_info tegra_udc_soc_info =3D {
>  	.flags =3D CI_HDRC_REQUIRES_ALIGNED_DMA |
> -		 CI_HDRC_OVERRIDE_PHY_CONTROL,
> +		 CI_HDRC_OVERRIDE_PHY_CONTROL |
> +		 CI_HDRC_SUPPORTS_RUNTIME_PM,
>  	.dr_mode =3D USB_DR_MODE_UNKNOWN,
>  };
> =20
> @@ -323,6 +326,10 @@ static int tegra_usb_probe(struct platform_device *p=
dev)
>  	usb->data.hub_control =3D tegra_ehci_hub_control;
>  	usb->data.notify_event =3D tegra_usb_notify_event;
> =20
> +	/* Tegra PHY driver currently doesn't support LPM for ULPI */
> +	if (of_usb_get_phy_mode(pdev->dev.of_node) =3D=3D USBPHY_INTERFACE_MODE=
_ULPI)
> +		usb->data.flags &=3D ~CI_HDRC_SUPPORTS_RUNTIME_PM;
> +

Does this prevent the wakeup_enabled from being set for ULPI PHYs?

Thierry

--n/D9wwuYCvcRgZHH
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl/bYA8ACgkQ3SOs138+
s6Hl5w/7BVkXve6VtsuqTT5P4adAwE8LOMKsR0XHw70c5khXTnLY7llcjsgeAQYk
6YP0XpHupIaF8fGjEDDohLRnyK/xAWQ2BkHyanHlolWSqYKSxssvcF5etkwiir2t
Gmq7Klsq4m9B1DeSDnhJj9rqSVhdDR+dVItPphjduL0g7OO8PslQB8m5oJUwuUNd
J9j2hFhjEeTLdJjItQEGNHBXtVzxx/b+YHFISZG3uIwnuzf0kZ6X+XgSDyONrso5
Etf2pLmQzchDWHomOoJgSgjZtTbjI9heKdVwG+hZd+hEQIS+m0kx1cxGPZrzNjh5
s61yFlYQOL1h2saheDY3OeG3k/wgATw2STIwauY+5/ERQQZhuR4UACeD2uPg89xI
0Wike8b/SWMgmv4V14nOFGNPhTTcQ3mXA+GdBzPznHwfhBXfmsfLaXXQJvA/gEjW
u4+u3MuPBkf/7t8bGwM7QY3Ia0rUHelOYSLyydKO4GNKSZO+Ldu9IRfg/7aGM70n
W6/c1LZIhUKMnOr4qXXm5ZZPYnVsDK814osk0wtqoU51auNqkeM1mQ9JrkV8fl57
7aefWjlNMvDOkpftfViwz6vYJsPqyN7e62khVWLXajCMW0K6nQie2K7DOBt0nQZL
2tCBA89CiJJzf3c/Hs9snd7H5v7aQqA9WncpYw92JXaJ/IRfns8=
=U/AY
-----END PGP SIGNATURE-----

--n/D9wwuYCvcRgZHH--