Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 6/8] usb: chipidea: tegra: Support runtime PM
To:     Thierry Reding <thierry.reding@gmail.com>
Cc:     Jonathan Hunter <jonathanh@nvidia.com>,
        Peter Chen <Peter.Chen@nxp.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        Felipe Balbi <balbi@kernel.org>,
        Matt Merhar <mattmerhar@protonmail.com>,
        Nicolas Chauvet <kwizart@gmail.com>,
        Peter Geis <pgwipeout@gmail.com>,
        Ion Agorria <ion@agorria.com>, linux-tegra@vger.kernel.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20201217094007.19336-1-digetx@gmail.com>
 <20201217094007.19336-7-digetx@gmail.com> <X9tgD+KSU1bIvht5@ulmo>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <28468e30-a832-9774-bed3-ac986aef8831@gmail.com>
Date:   Thu, 17 Dec 2020 16:45:03 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.2
MIME-Version: 1.0
In-Reply-To: <X9tgD+KSU1bIvht5@ulmo>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

17.12.2020 16:41, Thierry Reding пишет:
> On Thu, Dec 17, 2020 at 12:40:05PM +0300, Dmitry Osipenko wrote:
>> Tegra PHY driver now supports waking up controller from a low power mode.
>> Enable runtime PM in order to put controller into the LPM during idle.
>>
>> Tested-by: Matt Merhar <mattmerhar@protonmail.com>
>> Tested-by: Nicolas Chauvet <kwizart@gmail.com>
>> Tested-by: Peter Geis <pgwipeout@gmail.com>
>> Tested-by: Ion Agorria <ion@agorria.com>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>>  drivers/usb/chipidea/ci_hdrc_tegra.c | 13 ++++++++++---
>>  1 file changed, 10 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c b/drivers/usb/chipidea/ci_hdrc_tegra.c
>> index 5fccdeeefc64..655671159511 100644
>> --- a/drivers/usb/chipidea/ci_hdrc_tegra.c
>> +++ b/drivers/usb/chipidea/ci_hdrc_tegra.c
>> @@ -38,21 +38,24 @@ struct tegra_usb_soc_info {
>>  
>>  static const struct tegra_usb_soc_info tegra20_ehci_soc_info = {
>>  	.flags = CI_HDRC_REQUIRES_ALIGNED_DMA |
>> -		 CI_HDRC_OVERRIDE_PHY_CONTROL,
>> +		 CI_HDRC_OVERRIDE_PHY_CONTROL |
>> +		 CI_HDRC_SUPPORTS_RUNTIME_PM,
>>  	.dr_mode = USB_DR_MODE_HOST,
>>  	.txfifothresh = 10,
>>  };
>>  
>>  static const struct tegra_usb_soc_info tegra30_ehci_soc_info = {
>>  	.flags = CI_HDRC_REQUIRES_ALIGNED_DMA |
>> -		 CI_HDRC_OVERRIDE_PHY_CONTROL,
>> +		 CI_HDRC_OVERRIDE_PHY_CONTROL |
>> +		 CI_HDRC_SUPPORTS_RUNTIME_PM,
>>  	.dr_mode = USB_DR_MODE_HOST,
>>  	.txfifothresh = 16,
>>  };
>>  
>>  static const struct tegra_usb_soc_info tegra_udc_soc_info = {
>>  	.flags = CI_HDRC_REQUIRES_ALIGNED_DMA |
>> -		 CI_HDRC_OVERRIDE_PHY_CONTROL,
>> +		 CI_HDRC_OVERRIDE_PHY_CONTROL |
>> +		 CI_HDRC_SUPPORTS_RUNTIME_PM,
>>  	.dr_mode = USB_DR_MODE_UNKNOWN,
>>  };
>>  
>> @@ -323,6 +326,10 @@ static int tegra_usb_probe(struct platform_device *pdev)
>>  	usb->data.hub_control = tegra_ehci_hub_control;
>>  	usb->data.notify_event = tegra_usb_notify_event;
>>  
>> +	/* Tegra PHY driver currently doesn't support LPM for ULPI */
>> +	if (of_usb_get_phy_mode(pdev->dev.of_node) == USBPHY_INTERFACE_MODE_ULPI)
>> +		usb->data.flags &= ~CI_HDRC_SUPPORTS_RUNTIME_PM;
>> +
> 
> Does this prevent the wakeup_enabled from being set for ULPI PHYs?

Yes