Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 17 Dec 2020 16:04:53 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Dmitry Osipenko <digetx@gmail.com>
Cc:     Jonathan Hunter <jonathanh@nvidia.com>,
        Peter Chen <Peter.Chen@nxp.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        Felipe Balbi <balbi@kernel.org>,
        Matt Merhar <mattmerhar@protonmail.com>,
        Nicolas Chauvet <kwizart@gmail.com>,
        Peter Geis <pgwipeout@gmail.com>,
        Ion Agorria <ion@agorria.com>, linux-tegra@vger.kernel.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/8] usb: phy: tegra: Support waking up from a low
 power mode
Message-ID: <X9tzlWYKRS9FY9q3@ulmo>
References: <20201217094007.19336-1-digetx@gmail.com>
 <20201217094007.19336-3-digetx@gmail.com>
 <X9teRPo/MadN79NI@ulmo>
 <3c204a61-86ae-1bbe-1442-527831f15232@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="cOXpBbUiKUTaRQTC"
Content-Disposition: inline
In-Reply-To: <3c204a61-86ae-1bbe-1442-527831f15232@gmail.com>
User-Agent: Mutt/2.0.3 (a51f058f) (2020-12-04)
Precedence: bulk


--cOXpBbUiKUTaRQTC
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 17, 2020 at 04:47:50PM +0300, Dmitry Osipenko wrote:
> 17.12.2020 16:33, Thierry Reding =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> >> +	/* PHY won't resume if reset is asserted */
> >> +	if (phy->wakeup_enabled)
> >> +		goto chrg_cfg0;
> >> =20
> >>  	val =3D readl_relaxed(base + USB_SUSP_CTRL);
> >>  	val |=3D UTMIP_RESET;
> >>  	writel_relaxed(val, base + USB_SUSP_CTRL);
> >> =20
> >> +chrg_cfg0:
> > I found this diffcult to read until I realized that it was basically
> > just the equivalent of this:
> >=20
> > 	if (!phy->wakeup_enabled) {
> > 		val =3D readl_relaxed(base + USB_SUSP_CTRL);
> > 		val |=3D UTMIP_RESET;
> > 		writel_relaxed(val, base + USB_SUSP_CTRL);
> > 	}
> >=20
> >>  	val =3D readl_relaxed(base + UTMIP_BAT_CHRG_CFG0);
> >>  	val |=3D UTMIP_PD_CHRG;
> >>  	writel_relaxed(val, base + UTMIP_BAT_CHRG_CFG0);
> >> =20
> >> +	if (phy->wakeup_enabled)
> >> +		goto xcvr_cfg1;
> >> +
> >>  	val =3D readl_relaxed(base + UTMIP_XCVR_CFG0);
> >>  	val |=3D UTMIP_FORCE_PD_POWERDOWN | UTMIP_FORCE_PD2_POWERDOWN |
> >>  	       UTMIP_FORCE_PDZI_POWERDOWN;
> >>  	writel_relaxed(val, base + UTMIP_XCVR_CFG0);
> >> =20
> >> +xcvr_cfg1:
> > Similarly, I think this is more readable as:
> >=20
> > 	if (!phy->wakeup_enabled) {
> > 		val =3D readl_relaxed(base + UTMIP_XCVR_CFG0);
> > 		val |=3D UTMIP_FORCE_PD_POWERDOWN | UTMIP_FORCE_PD2_POWERDOWN |
> > 		       UTMIP_FORCE_PDZI_POWERDOWN;
> > 		writel_relaxed(val, base + UTMIP_XCVR_CFG0);
> > 	}
> >=20
> >>  	val =3D readl_relaxed(base + UTMIP_XCVR_CFG1);
> >>  	val |=3D UTMIP_FORCE_PDDISC_POWERDOWN | UTMIP_FORCE_PDCHRP_POWERDOWN=
 |
> >>  	       UTMIP_FORCE_PDDR_POWERDOWN;
> >>  	writel_relaxed(val, base + UTMIP_XCVR_CFG1);
> >> =20
> >> +	if (phy->wakeup_enabled) {
> > Which then also matches the style of this conditional here.
>=20
> I'll change it in v3, thanks.

Given that my other comment about the WARN_ONCE seems to have been
resolved, with the above gotos replaced by conditionals as I suggested:

Acked-by: Thierry Reding <treding@nvidia.com>

--cOXpBbUiKUTaRQTC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl/bc5UACgkQ3SOs138+
s6EBzxAAq3HvcNtFiWElWKh9GGfrXYJAGBC3RHJPAOe0lYIfQlvBBbCnatiPqEEm
IfdoQcNF0EejAYZ6TvkUvICIpbJ9gNv2mes7MW+7qg4+rml76dAcVlPde0lap9oj
1J0qKl9bcwckRsCIHsa+A0NK2vf1BO/Slh4y5YqHJf6F2cU0YZBjX5DiqjYnaDyD
tx7CuZDcuwaUDHSfSZECL2fCmqdSkcUrXI3tLGTnS4OUualtZUh843Lf8fWoouAj
7ZHuA+SYx+ZgTbM7OZczx2h7mBYb4LGHAIkqyj57ZFu5GZozZBgZ+oqIp9QRw343
UoznZj/kpj64oNQI3WG8ecSG8vhObHRzgpqiX7+OzhAXMceRr41SuXglJOiqpi2d
/uk8i1sqG+SVET1BjsPukhQXetvt5QwaXQly2vMad/vNkUrzrAlefjSduKJ2i5Gz
1p4eDwpRpQ+VLZy/6zCOJjGmXUJAfCA+tUfCKcJwvaaVyLcjcKczCBomHdcwLrQG
Nii7y1ctcHxG5mhTxHDbgx9cQtWqVuSosDylVp7MZweJTYTVIHDJ/EG/Q9IUqcCh
aSj99DKpY8LMB+fvCgz+6oF2iBvjC2NoinOcV0s5AtXFbX9VDc1SO8EpLPaxhWX+
5S7dZkM2aJBlL8IWSNKCorDvcOSaU0yX/n3Ho/hEZz0OuBhht9M=
=E4e/
-----END PGP SIGNATURE-----

--cOXpBbUiKUTaRQTC--