Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964823AbWIDMTf (ORCPT ); Mon, 4 Sep 2006 08:19:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964771AbWIDMTf (ORCPT ); Mon, 4 Sep 2006 08:19:35 -0400 Received: from mailhub.sw.ru ([195.214.233.200]:5232 "EHLO relay.sw.ru") by vger.kernel.org with ESMTP id S964848AbWIDMTd (ORCPT ); Mon, 4 Sep 2006 08:19:33 -0400 Message-ID: <44FC1AAF.8040504@sw.ru> Date: Mon, 04 Sep 2006 16:23:11 +0400 From: Kirill Korotaev User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060417 X-Accept-Language: en-us, en, ru MIME-Version: 1.0 To: Dave Hansen CC: Rik van Riel , CKRM-Tech , Andi Kleen , Linux Kernel Mailing List , Christoph Hellwig , Andrey Savochkin , devel@openvz.org, Matt Helsley , Alexey Dobriyan , Oleg Nesterov , Alan Cox , Pavel Emelianov Subject: Re: [ckrm-tech] [PATCH 6/7] BC: kernel memory (core) References: <44F45045.70402@sw.ru> <44F45601.9060807@sw.ru> <1156883382.5408.153.camel@localhost.localdomain> In-Reply-To: <1156883382.5408.153.camel@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1676 Lines: 53 Dave Hansen wrote: > On Tue, 2006-08-29 at 18:58 +0400, Kirill Korotaev wrote: > >>@@ -274,8 +274,14 @@ struct page { >> unsigned int gfp_mask; >> unsigned long trace[8]; >> #endif >>+#ifdef CONFIG_BEANCOUNTERS >>+ union { >>+ struct beancounter *page_bc; >>+ } bc; >>+#endif >> }; > > > I know you're probably saving this union for when you put some userspace > stuff in here or something. But, for now, it would probably be best > just to leave it as a plain struct, or even an anonymous union. > > You probably had to use gcc 2 when this was written and couldn't use > anonymous unions, right? are you suggesting the code like this: >>+#ifdef CONFIG_BEANCOUNTERS >>+ union { >>+ struct beancounter *page_bc; >>+ }; >>+#endif >> }; #define page_bc(page) ((page)->page_bc) ? > -- Dave > > > ------------------------------------------------------------------------- > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > _______________________________________________ > ckrm-tech mailing list > https://lists.sourceforge.net/lists/listinfo/ckrm-tech > -- VGER BF report: H 5.55112e-17 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/