Date: Mon, 4 Sep 2006 14:43:35 +0200
From: Jens Axboe <axboe@kernel.dk>
To: Milan Broz <mbroz@redhat.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] fix creating zero sized bio mempools in low memory system
Message-ID: <20060904124335.GM25434@kernel.dk>
References: <44FC1C90.200@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <44FC1C90.200@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 884
Lines: 24

On Mon, Sep 04 2006, Milan Broz wrote:
> In the very low memory systems is in the init_bio call
> scale parameter set to zero and it leads to creating
> zero sized mempool.
> 
> This patch prevents pool_entries parameter become zero,
> so the created pool have at least 1 entry.
> 
> Mempool with 0 entries lead to incorrect behaviour 
> of mempool_free. (Alloc requests are not waken up
> and system stalls in mempool_alloc->ioschedule). 

Good catch, queued. Maybe this is the only such scaling problem,
otherwise it may be a good idea to add a WARN_ON(!min_nr) to the mempool
setup in mm/mempool.c to catch such errors.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/