Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   ebiederm@xmission.com (Eric W. Biederman)
To:     "Alejandro Colomar \(man-pages\)" <alx.manpages@gmail.com>
Cc:     Oleg Nesterov <oleg@tv-sign.ru>, Jann Horn <jannh@google.com>,
        Ted Estes <ted@softwarecrafters.com>,
        Jann Horn <jann@thejh.net>, Pavel Emelyanov <xemul@openvz.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Michael Kerrisk <mtk.manpages@gmail.com>,
        Kees Cook <keescook@chromium.org>,
        linux-man <linux-man@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Darren Hart <dvhart@infradead.org>
References: <feef4f9a-4ed8-8a2e-d330-88e7f516faae@gmail.com>
        <X9lBp3BHbwcTmDqb@pc.thejh.net>
        <0e5189c0-9e9b-ac34-825c-619a9a6ef682@gmail.com>
        <d38c5e8b-1653-d89a-a0c8-b95cb1844fba@gmail.com>
        <CAG48ez0y21uWBDuaczLMxLPpFTKABrgm+-aqLb-0a4rHuOCX-g@mail.gmail.com>
        <5062fe43-ca37-134f-89ad-57fbd8c312ba@softwarecrafters.com>
        <CAG48ez2g=U-H56g6VebQCiSXGg+bVvhBA5yfwymNxVYAGEJJcA@mail.gmail.com>
        <1abbf267-d522-0586-e5a5-c71f4d7b0fa4@gmail.com>
Date:   Thu, 17 Dec 2020 12:45:29 -0600
In-Reply-To: <1abbf267-d522-0586-e5a5-c71f4d7b0fa4@gmail.com> (Alejandro
        Colomar's message of "Wed, 16 Dec 2020 10:22:09 +0100")
Message-ID: <87eejouv92.fsf@x220.int.ebiederm.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Bug 210655] ptrace.2: documentation is incorrect about access checking threads in same thread group
Precedence: bulk

"Alejandro Colomar (man-pages)" <alx.manpages@gmail.com> writes:

> [CC += Thomas, Ingo, Peter, Darren]
>
> Hi Oleg,
>
> On 12/16/20 3:33 AM, Jann Horn wrote:
>> On Wed, Dec 16, 2020 at 3:21 AM Ted Estes <ted@softwarecrafters.com> wrote:
>>> On 12/15/2020 6:01 PM, Jann Horn wrote:
>>>> On Wed, Dec 16, 2020 at 12:25 AM Alejandro Colomar (man-pages)
>>>> <alx.manpages@gmail.com> wrote:
>>>>> On 12/16/20 12:23 AM, Alejandro Colomar (man-pages) wrote:
>>>>>> On 12/16/20 12:07 AM, Jann Horn wrote:
>>>>>>> As the comment explains, you can't actually *attach*
>>>>>>> to another task in the same thread group; but that's
>>>>>>> not because of the ptrace-style access check rules,
>>>>>>> but because specifically *attaching* to another task
>>>>>>> in the same thread group doesn't work.
>>>> As I said, attaching indeed doesn't work. But that's not what "Ptrace
>>>> access mode checking" means. As the first sentence of that section
>>>> says:
>>>>
>>>> | Various parts of the kernel-user-space API (not just ptrace()
>>>> | operations), require so-called "ptrace access mode" checks,
>>>> | whose outcome determines whether an operation is
>>>> | permitted (or, in a  few cases,  causes  a "read" operation
>>>> | to return sanitized data).
>>>>
>>>> You can find these places by grepping for \bptrace_may_access\b -
>>>> operations like e.g. the get_robust_list() syscall will always succeed
>>>> when inspecting other tasks in the caller's thread group thanks to
>>>> this rule.
>>>
>>> Ah, yes.  I missed that back reference while trying to digest that
>>> rather meaty man page.  A grep on the man page source tree does show a
>>> number of references to "ptrace access mode".
>>>
>>> That said, the ptrace(2) man page also directly references the ptrace
>>> access mode check under both PTRACE_ATTACH and PTACE_SEIZE:
>>>
>>> | Permission to perform a PTRACE_ATTACH is governed by a ptrace | access
>>> mode PTRACE_MODE_ATTACH_REALCREDS check; see below. As confirmed, the
>>> "same thread group" rule does not apply to either of those operations. A
>>> re-wording of rule 1 similar to this might help avoid confusion: 1. If
>>> the calling thread and the target thread are in the same thread group:
>>> a. For ptrace() called with PTRACE_ATTACH or PTRACE_SEIZE, access is
>>> NEVER allowed. b. For all other so-called "ptrace access mode checks",
>>> access is ALWAYS allowed. --Ted
>> 
>> Yeah, maybe. OTOH I'm not sure whether it really makes sense to
>> explain this as being part of a security check, or whether it should
>> be explained separately as a restriction on PTRACE_ATTACH and
>> PTRACE_SEIZE (with a note like "(irrelevant for ptrace attachment)" on
>> rule 1). But I don't feel strongly about it either way.
>> 
>
> As you are the maintainer for ptrace,
> could you confirm the above from Jan?
> And maybe suggest what you would do with the manual page.
>
> I'd like to get confirmation that there are still other functions that
> require "ptrace access mode" other than ptrace() itself, where it's
> valid that the calling thread and the target thread are in the same
> group.

Large swaths of proc are governed by those checks.

In general in the kernel whenever you are accessing another process to
perform an operation (especially reading) it will probably use
"ptrace access mode" checks.

You can see this by with "git grep ptrace_may_access" on the kernel source.

Eric