Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1493603pxu; Thu, 17 Dec 2020 11:14:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJw0fQrm8/h38XNDZVlA4ch0X2fnd7BXTM8xHGLq90gOcGGfN04FWA0YMRrztjmNrOsYA0i0 X-Received: by 2002:a50:8387:: with SMTP id 7mr827687edi.131.1608232444797; Thu, 17 Dec 2020 11:14:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608232444; cv=none; d=google.com; s=arc-20160816; b=AyZYIqCSg4goWYk/W7AlZ7rx+TeEqcBrPgaxLKJ9K3M3JIWUC1Q7U5lsJjjx1QeyrE xwwfB1pW5FD38+i6AsuKQPImS7a6Ii+gUJ3gr04bmAyTDYuosQJgNgSt9gGTohrW1/T1 6sOhvoq0DyzrhN+RwtLqjrnC1IG87h4rgCyqII9otGhqd3I1EPsaWLuGDB6BlhLUol5O bf92/dNwlMO0VBIDWaS++TEjY5iulZqAnQO9xTkvQbr9VD+n8bpH7dGTd/h+ej5Va27V yjIIJSMozSP6TJ0wM5yJHNODsga30i0GUohKzSQ5BpWmOSZdisTc5I0zLfh7t2eIZXJy zvWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=w6Y5dVodJg7NGyGrDapL29dhygM6+dpwE6U7NTYVpEw=; b=giTUOYF36zstuXZH44aTCIQ/IU2Bzk/dHrZfeWFaVBpIFyKesnr1eO21yFnao+YKf9 scqCSeJ4YgH9aqLm7Dkj4P+qV6Y/767tkz8orzKam2psYk7w+fZoXSUA5Yw6U/FNh4M2 3ei2CDDIv18IB8gNdQQN2qhYF0J4KGwllBGq4Bzh0OX5alZgVHBoj48MhmFHA7y/g+J5 xzYVKnUdhC04maEdnEYBGBP1swPb09fO/9/zIeKvdmXiBaU3Ng+2yCkyu4a2AW6JhDEe 5bQLPZHmiv8hdlLUW4vNQaEWjRh3bWsH8TZ42sUjvseiQU8VhPmFzuclXlfqxIohRCVZ 5eOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=PH29CFyJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q10si3104172ejt.370.2020.12.17.11.13.40; Thu, 17 Dec 2020 11:14:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=PH29CFyJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730955AbgLQTMR (ORCPT + 99 others); Thu, 17 Dec 2020 14:12:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730436AbgLQTMQ (ORCPT ); Thu, 17 Dec 2020 14:12:16 -0500 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DEBAC0617A7 for ; Thu, 17 Dec 2020 11:11:36 -0800 (PST) Received: by mail-pl1-x633.google.com with SMTP id 4so29765plk.5 for ; Thu, 17 Dec 2020 11:11:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to; bh=w6Y5dVodJg7NGyGrDapL29dhygM6+dpwE6U7NTYVpEw=; b=PH29CFyJ7NmEDPEhcZ4IfhjFnpwMoKiiJcH2wKmlWxzokjoy1JYGFOEqGL7B7pBG0h IEmg7mxmADzNXNT/eyoW59YkcAQZf4p0RuK9DDEXf4HOFWl9GAzUE6qTQD5ONOCdf/i3 Y6fc3TTxHBUVlrQH+hxaD8G6FM2Jg8TGGAg1I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to; bh=w6Y5dVodJg7NGyGrDapL29dhygM6+dpwE6U7NTYVpEw=; b=R+EEWKnAdTw2vHcW2rr7SRmK70o/IuAnoTFA97ObDmTJ2yrNaNU3wfTl4pAuQx+vtd aZhHwX2oF2Unt2pe+gv9bbd0WSEUDLiihVDIxjJSj1BsX12uUyXFpAyql1fM3OUetWjZ 6GJM4Y5a4eOT7p8rqadtJ8DpCwGARr03bHtLvR7ZQ0KygZcl1a1hvnjVKW/EPj1hoywl qhmRC38B5tK3h+sk3ssvdeIrfaFhdyCQR9B/na2Ny00khukhN/D9gw8aaPG9RHT8p3rL qnQWp8+FODaTw5xh7N37ni/xPCVBloQTeBr/Xrhvsk13vGwmFs6sSgKfCFm5yi24++O7 XJLQ== X-Gm-Message-State: AOAM533ojWYgEQnG67zrjz6hevdNB8szdQTo5Zw+gQ5PhYSWfW5nWcYa ciDkoNx2WsrOMk+Wd6tnYEleaa4Ajp/azGh7IHDMqstmwSH1cf741vDaFH1+UioCHnTAoBMOr9m vld+kt0IXHaszG70= X-Received: by 2002:a17:90a:6486:: with SMTP id h6mr656107pjj.142.1608232295586; Thu, 17 Dec 2020 11:11:35 -0800 (PST) Received: from [10.136.50.213] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id i130sm6352463pfe.94.2020.12.17.11.11.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Dec 2020 11:11:34 -0800 (PST) Subject: Re: [PATCH v3 5/6] i2c: iproc: handle master read request To: Rayagonda Kokatanur , Wolfram Sang , Dhananjay Phadke , Andy Shevchenko , BCM Kernel Feedback , Brendan Higgins , Florian Fainelli , linux-arm Mailing List , linux-i2c , Linux Kernel Mailing List , Lori Hikichi , Ray Jui , Scott Branden References: <38a23afc-57da-a01f-286c-15f8b3d61705@broadcom.com> <1605316659-3422-1-git-send-email-dphadke@linux.microsoft.com> <20201202143505.GA874@kunai> <23a2f2e8-06ad-c728-98eb-91b164572ba4@broadcom.com> From: Ray Jui Message-ID: <35541129-df37-fa6f-5dae-34eb34a78731@broadcom.com> Date: Thu, 17 Dec 2020 11:11:31 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000bb290d05b6adc2e2" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --000000000000bb290d05b6adc2e2 Content-Type: text/plain; charset="UTF-8" Content-Language: en-US On 12/16/2020 8:08 PM, Rayagonda Kokatanur wrote: > On Wed, Dec 2, 2020 at 11:14 PM Ray Jui wrote: >> >> >> >> On 12/2/2020 6:35 AM, Wolfram Sang wrote: >>> >>>> All review comments are scattered now, please let me know what has to be >>>> done further, >>>> Are we going to change the tasklet to irq thread ? >>>> Are we going to remove batching 64 packets if transaction > 64B and use rx >>>> fifo threshold ? >>>> >>>> I don't see any issue with current code but if it has to change we need a >>>> valid reason for the same. >>>> If nothing to be done, please acknowledge the patch. >>> >>> Valid request. Has there been any news? >>> >> >> Sorry for the delay. I just replied. > > This patch is tested and validated with all corner cases and its working. > Can we merge this and take up any improvement as part of separate patch? > I think that makes sense, and I'm okay with these patches going in as they are now. Acked-by: Ray Jui But please help to collect precise FIFO access timing (later when you have time), that would allow us to know if the current defer-to-tasklet (instead of thread) based approach makes sense or not. Thanks, Ray > Thanks, > Rayagonda > >> >> >> Thanks, >> >> Ray -- This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it. --000000000000bb290d05b6adc2e2 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQMwYJKoZIhvcNAQcCoIIQJDCCECACAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg2IMIIE6DCCA9CgAwIBAgIOSBtqCRO9gCTKXSLwFPMwDQYJKoZIhvcNAQELBQAwTDEgMB4GA1UE CxMXR2xvYmFsU2lnbiBSb290IENBIC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMT Ckdsb2JhbFNpZ24wHhcNMTYwNjE1MDAwMDAwWhcNMjQwNjE1MDAwMDAwWjBdMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTEzMDEGA1UEAxMqR2xvYmFsU2lnbiBQZXJzb25h bFNpZ24gMiBDQSAtIFNIQTI1NiAtIEczMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA tpZok2X9LAHsYqMNVL+Ly6RDkaKar7GD8rVtb9nw6tzPFnvXGeOEA4X5xh9wjx9sScVpGR5wkTg1 fgJIXTlrGESmaqXIdPRd9YQ+Yx9xRIIIPu3Jp/bpbiZBKYDJSbr/2Xago7sb9nnfSyjTSnucUcIP ZVChn6hKneVGBI2DT9yyyD3PmCEJmEzA8Y96qT83JmVH2GaPSSbCw0C+Zj1s/zqtKUbwE5zh8uuZ p4vC019QbaIOb8cGlzgvTqGORwK0gwDYpOO6QQdg5d03WvIHwTunnJdoLrfvqUg2vOlpqJmqR+nH 9lHS+bEstsVJtZieU1Pa+3LzfA/4cT7XA/pnwwIDAQABo4IBtTCCAbEwDgYDVR0PAQH/BAQDAgEG MGoGA1UdJQRjMGEGCCsGAQUFBwMCBggrBgEFBQcDBAYIKwYBBQUHAwkGCisGAQQBgjcUAgIGCisG AQQBgjcKAwQGCSsGAQQBgjcVBgYKKwYBBAGCNwoDDAYIKwYBBQUHAwcGCCsGAQUFBwMRMBIGA1Ud EwEB/wQIMAYBAf8CAQAwHQYDVR0OBBYEFGlygmIxZ5VEhXeRgMQENkmdewthMB8GA1UdIwQYMBaA FI/wS3+oLkUkrk1Q+mOai97i3Ru8MD4GCCsGAQUFBwEBBDIwMDAuBggrBgEFBQcwAYYiaHR0cDov L29jc3AyLmdsb2JhbHNpZ24uY29tL3Jvb3RyMzA2BgNVHR8ELzAtMCugKaAnhiVodHRwOi8vY3Js Lmdsb2JhbHNpZ24uY29tL3Jvb3QtcjMuY3JsMGcGA1UdIARgMF4wCwYJKwYBBAGgMgEoMAwGCisG AQQBoDIBKAowQQYJKwYBBAGgMgFfMDQwMgYIKwYBBQUHAgEWJmh0dHBzOi8vd3d3Lmdsb2JhbHNp Z24uY29tL3JlcG9zaXRvcnkvMA0GCSqGSIb3DQEBCwUAA4IBAQConc0yzHxn4gtQ16VccKNm4iXv 6rS2UzBuhxI3XDPiwihW45O9RZXzWNgVcUzz5IKJFL7+pcxHvesGVII+5r++9eqI9XnEKCILjHr2 DgvjKq5Jmg6bwifybLYbVUoBthnhaFB0WLwSRRhPrt5eGxMw51UmNICi/hSKBKsHhGFSEaJQALZy 4HL0EWduE6ILYAjX6BSXRDtHFeUPddb46f5Hf5rzITGLsn9BIpoOVrgS878O4JnfUWQi29yBfn75 HajifFvPC+uqn+rcVnvrpLgsLOYG/64kWX/FRH8+mhVe+mcSX3xsUpcxK9q9vLTVtroU/yJUmEC4 OcH5dQsbHBqjMIIDXzCCAkegAwIBAgILBAAAAAABIVhTCKIwDQYJKoZIhvcNAQELBQAwTDEgMB4G A1UECxMXR2xvYmFsU2lnbiBSb290IENBIC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNV BAMTCkdsb2JhbFNpZ24wHhcNMDkwMzE4MTAwMDAwWhcNMjkwMzE4MTAwMDAwWjBMMSAwHgYDVQQL ExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UEAxMK R2xvYmFsU2lnbjCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAMwldpB5BngiFvXAg7aE yiie/QV2EcWtiHL8RgJDx7KKnQRfJMsuS+FggkbhUqsMgUdwbN1k0ev1LKMPgj0MK66X17YUhhB5 uzsTgHeMCOFJ0mpiLx9e+pZo34knlTifBtc+ycsmWQ1z3rDI6SYOgxXG71uL0gRgykmmKPZpO/bL yCiR5Z2KYVc3rHQU3HTgOu5yLy6c+9C7v/U9AOEGM+iCK65TpjoWc4zdQQ4gOsC0p6Hpsk+QLjJg 6VfLuQSSaGjlOCZgdbKfd/+RFO+uIEn8rUAVSNECMWEZXriX7613t2Saer9fwRPvm2L7DWzgVGkW qQPabumDk3F2xmmFghcCAwEAAaNCMEAwDgYDVR0PAQH/BAQDAgEGMA8GA1UdEwEB/wQFMAMBAf8w HQYDVR0OBBYEFI/wS3+oLkUkrk1Q+mOai97i3Ru8MA0GCSqGSIb3DQEBCwUAA4IBAQBLQNvAUKr+ yAzv95ZURUm7lgAJQayzE4aGKAczymvmdLm6AC2upArT9fHxD4q/c2dKg8dEe3jgr25sbwMpjjM5 RcOO5LlXbKr8EpbsU8Yt5CRsuZRj+9xTaGdWPoO4zzUhw8lo/s7awlOqzJCK6fBdRoyV3XpYKBov Hd7NADdBj+1EbddTKJd+82cEHhXXipa0095MJ6RMG3NzdvQXmcIfeg7jLQitChws/zyrVQ4PkX42 68NXSb7hLi18YIvDQVETI53O9zJrlAGomecsMx86OyXShkDOOyyGeMlhLxS67ttVb9+E7gUJTb0o 2HLO02JQZR7rkpeDMdmztcpHWD9fMIIFNTCCBB2gAwIBAgIMJQxqAs0uKXLnVqjWMA0GCSqGSIb3 DQEBCwUAMF0xCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTMwMQYDVQQD EypHbG9iYWxTaWduIFBlcnNvbmFsU2lnbiAyIENBIC0gU0hBMjU2IC0gRzMwHhcNMjAwOTIxMTQz MTQ3WhcNMjIwOTIyMTQzMTQ3WjCBhDELMAkGA1UEBhMCSU4xEjAQBgNVBAgTCUthcm5hdGFrYTES MBAGA1UEBxMJQmFuZ2Fsb3JlMRYwFAYDVQQKEw1Ccm9hZGNvbSBJbmMuMRAwDgYDVQQDEwdSYXkg SnVpMSMwIQYJKoZIhvcNAQkBFhRyYXkuanVpQGJyb2FkY29tLmNvbTCCASIwDQYJKoZIhvcNAQEB BQADggEPADCCAQoCggEBAKn4hxAQIaUc/63CGGAfKpCpBLQZU/mobqbKwTdwXmkNVlWkldmfbV1C wdSx9vgMN7hDrNLmOcurXjYSYT0seO6NLnsRvQ6lc2v92pqK7i8HwzTOL/b9z4XC5VnoYcHRuz75 IcF8U8x+x6Rq4UutUQgoQDREvwBcsCj6ZDNmxDaEyyIflO3+HYvjI2hpJFOd+Wt5H/l9Nq1r7OLj jtK7Nlq1VqsruL98ME7ID5QhbF4tLGQgZEw250Sctjx8R8+zZPNxIIDREhAsGiupe5j3rEXDFv39 Gp3tsmw0Vz7IMJs6DQIm7T8CfIzeId1IIHcH02MbpO7m1Btzyz625FoBWF8CAwEAAaOCAcswggHH MA4GA1UdDwEB/wQEAwIFoDCBngYIKwYBBQUHAQEEgZEwgY4wTQYIKwYBBQUHMAKGQWh0dHA6Ly9z ZWN1cmUuZ2xvYmFsc2lnbi5jb20vY2FjZXJ0L2dzcGVyc29uYWxzaWduMnNoYTJnM29jc3AuY3J0 MD0GCCsGAQUFBzABhjFodHRwOi8vb2NzcDIuZ2xvYmFsc2lnbi5jb20vZ3NwZXJzb25hbHNpZ24y c2hhMmczME0GA1UdIARGMEQwQgYKKwYBBAGgMgEoCjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3 dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAJBgNVHRMEAjAAMEQGA1UdHwQ9MDswOaA3oDWG M2h0dHA6Ly9jcmwuZ2xvYmFsc2lnbi5jb20vZ3NwZXJzb25hbHNpZ24yc2hhMmczLmNybDAfBgNV HREEGDAWgRRyYXkuanVpQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEFBQcDBDAfBgNVHSME GDAWgBRpcoJiMWeVRIV3kYDEBDZJnXsLYTAdBgNVHQ4EFgQUvUTLkCwFvnpejW/KGvdaDA31b+sw DQYJKoZIhvcNAQELBQADggEBACMny/9Y1OPK7qwiBKBMt478eBgXnTlJ0J0HNebYcxN/l7fKIKMb /eX/AQKIDsHeshmV2ekPU4yY/04veXx3QTgmE1bb4ksKEFEbU0LXlVPrnlgNn8M75cPymegn/2yU r1+htd2eve3obmKc5Lrl0GP+4m72XxAOL687Aw5vRa4Lf294s+x4d+VRwUjoFTj9zyLhexWQuJv/ yX1HjSkrlIsRwi6DN0/ieL04O9aD1UNPlCC6akGnv4tgwlESh51M564qhonlfSW6La+L/aTIuQc0 88lq8s/VMBBGdc7176/v5TbNwEC/c5QYbp2n76rAmKKjhjwWmBk64yLT7CoIxk0xggJvMIICawIB ATBtMF0xCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTMwMQYDVQQDEypH bG9iYWxTaWduIFBlcnNvbmFsU2lnbiAyIENBIC0gU0hBMjU2IC0gRzMCDCUMagLNLily51ao1jAN BglghkgBZQMEAgEFAKCB1DAvBgkqhkiG9w0BCQQxIgQgkPrb1RD5WUP263ql6Wto8CVLc+OK0Hmt J4JsADT/q0swGAYJKoZIhvcNAQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMjAxMjE3 MTkxMTM2WjBpBgkqhkiG9w0BCQ8xXDBaMAsGCWCGSAFlAwQBKjALBglghkgBZQMEARYwCwYJYIZI AWUDBAECMAoGCCqGSIb3DQMHMAsGCSqGSIb3DQEBCjALBgkqhkiG9w0BAQcwCwYJYIZIAWUDBAIB MA0GCSqGSIb3DQEBAQUABIIBACAn+tFxym7EMdEJK+wKafXHyTJ0JL7EN4pkeaJUythQk0/UqONs RQP4rqRjF4AhMwZMGki2/OD5aCGf/yzoDLTKd6OeaBHT3JGsO2g2TNF8gvsmbQt9sutGTaFynk3n YtPyIJRGD30XgUzry6DYbJksDUo2aGLd/3v/OHPhMXEyypJlX7LqOVP3x4yDHecsvcgfWq1hFQU2 IpaKHccGcM3Jx8zeRzxRqpIlFqHrmr3kDFsVleM54KzOAHRa58JAexzhrkVnOanuDjaqDOgnqLHH 3nRtZrYZs4Fbjv9Us4b42YVpHIGLzLWP5Z1W85pZxsZ0knC5opksaId3LL6o1gM= --000000000000bb290d05b6adc2e2--