Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Lukasz Stelmach <l.stelmach@samsung.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Andrew Lunn <andrew@lunn.ch>, jim.cromie@gmail.com,
        Heiner Kallweit <hkallweit1@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Rob Herring <robh+dt@kernel.org>,
        Kukjin Kim <kgene@kernel.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Russell King <linux@armlinux.org.uk>, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org,
        =?utf-8?Q?Bart=C5=82omiej_=C5=BBolni?= =?utf-8?Q?erkiewicz?= 
        <b.zolnierkie@samsung.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v9 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet
 Adapter Driver
Date:   Thu, 17 Dec 2020 21:11:10 +0100
In-Reply-To: <20201217110851.4a059426@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
        (Jakub Kicinski's message of "Thu, 17 Dec 2020 11:08:51 -0800")
Message-ID: <dleftjk0tg6vmp.fsf%l.stelmach@samsung.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
        protocol="application/pgp-signature"
CMS-TYPE: 201P
References: <20201217110851.4a059426@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
        <CGME20201217201121eucas1p1147efa18e8ae36db188cae200bc21e4d@eucas1p1.samsung.com>
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2020-12-17 czw 11:08>, when Jakub Kicinski wrote:
> On Thu, 17 Dec 2020 12:53:30 +0100 =C5=81ukasz Stelmach wrote:
>> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be
>> connected to a CPU with a 8/16-bit bus or with an SPI. This driver
>> supports SPI connection.
>>=20
>> The driver has been ported from the vendor kernel for ARTIK5[2]
>> boards. Several changes were made to adapt it to the current kernel
>> which include:
>>=20
>> + updated DT configuration,
>> + clock configuration moved to DT,
>> + new timer, ethtool and gpio APIs,
>> + dev_* instead of pr_* and custom printk() wrappers,
>> + removed awkward vendor power managemtn.
>> + introduced ethtool tunable to control SPI compression
>>=20

[...]

>>=20
>> The other ax88796 driver is for NE2000 compatible AX88796L chip. These
>> chips are not compatible. Hence, two separate drivers are required.
>>=20
>> Signed-off-by: =C5=81ukasz Stelmach <l.stelmach@samsung.com>
>> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> drivers/net/ethernet/asix/ax88796c_main.c: In function =E2=80=98ax88796c_=
tx_fixup=E2=80=99:
> drivers/net/ethernet/asix/ax88796c_main.c:248:6: warning: variable =E2=80=
=98tol_len=E2=80=99 set but not used [-Wunused-but-set-variable]
>   248 |  u16 tol_len, pkt_len;
>       |      ^~~~~~~

Done. Thanks.

=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAl/bu14ACgkQsK4enJil
gBDPsQf8CSIAfSlfu6USnUeTjFPC7ww9FQ4bu869KBTSUDJHn4bzc+dJuyfb1yMq
34k2THjWDp8sWNDCoF4A0fWZbrBIwsg1vPFA+ave1KHxCe5mp1J4VzctqN1sIWmU
woW98UNIfgWdmS/Cb5TRh0In94a3yY/YypPICSPBbs6zuWIIrCHEJKUt1LEzgTx7
Q6nY0UeCs4Skpbaki/xDo3+uB6bXoRT/kQvnroy3DMCn8qBaX9N961BZUyzYYEg1
Upja6i+Md4k6UCCunktMtnlHfloXwO3TtVGpisq9eb0Ey/1+pJzD8wNKTOggLBsB
UhmtvRkvloftPEQSgBlGicJ4kNzBfg==
=Toi6
-----END PGP SIGNATURE-----
--=-=-=--