Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] clk: exynos7: Mark aclk_fsys1_200 as critical
To:     Stephen Boyd <sboyd@kernel.org>, kgene@kernel.org, krzk@kernel.org,
        mturquette@baylibre.com
Cc:     s.nawrocki@samsung.com, tomasz.figa@gmail.com,
        cw00.choi@samsung.com, linux-samsung-soc@vger.kernel.org,
        linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <20201024154346.9589-1-pawel.mikolaj.chmiel@gmail.com>
 <160820006410.1580929.8444804722224099547@swboyd.mtv.corp.google.com>
From:   =?UTF-8?Q?Pawe=c5=82_Chmiel?= <pawel.mikolaj.chmiel@gmail.com>
Message-ID: <61a6d576-9f91-dd2c-fd09-7e243f6ec7be@gmail.com>
Date:   Thu, 17 Dec 2020 22:08:50 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <160820006410.1580929.8444804722224099547@swboyd.mtv.corp.google.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 17.12.2020 11:14, Stephen Boyd wrote:
> Not sure why this wasn't picked up in the samsung PR. Can you resend?
Hi
There was v2
(https://patchwork.kernel.org/project/linux-samsung-soc/patch/20201107121456.25562-1-pawel.mikolaj.chmiel@gmail.com/)
but it did receive some request for changes comments and i didn't yet
had time to it.

> 
>> diff --git a/drivers/clk/samsung/clk-exynos7.c b/drivers/clk/samsung/clk-exynos7.c
>> index c1ff715e960c..1048d83f097b 100644
>> --- a/drivers/clk/samsung/clk-exynos7.c
>> +++ b/drivers/clk/samsung/clk-exynos7.c
>> @@ -538,7 +538,8 @@ static const struct samsung_gate_clock top1_gate_clks[] __initconst = {
>>                 ENABLE_ACLK_TOP13, 28, CLK_SET_RATE_PARENT |
>>                 CLK_IS_CRITICAL, 0),
>>         GATE(CLK_ACLK_FSYS1_200, "aclk_fsys1_200", "dout_aclk_fsys1_200",
>> -               ENABLE_ACLK_TOP13, 24, CLK_SET_RATE_PARENT, 0),
>> +               ENABLE_ACLK_TOP13, 24, CLK_SET_RATE_PARENT |
>> +               CLK_IS_CRITICAL, 0),
>>  
> 
> Please put a comment in the code why a clk is critica>