Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1580853pxu; Thu, 17 Dec 2020 13:27:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJy9fi78QUElvNhAOmzl9axuY8GTvygLp6V5O+GfXl6v8nI2dzxB237f84gjNJsa9MA9lLAS X-Received: by 2002:a17:906:edd2:: with SMTP id sb18mr1031647ejb.114.1608240461647; Thu, 17 Dec 2020 13:27:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608240461; cv=none; d=google.com; s=arc-20160816; b=WWSGdZMxSogiBUQGC+ndpY1YC9zr45OVYuo37bPh+x22YrlrzbyA2XnLTdMiSivTHV fKSUw2ESZ90hXLCqvXy1mHxswXd1FXaltsvl/1ixm7yqg9uRCplvKvhswsXAz4+Feg/e 71dBi4Sdmq5FuQtHIbemebUkFnEowsDijVex2rUvN1I/+SGv5SERMjyq3JCD0CDZgxkE rgNGeXult7UoilJjc2SPvLeXJus/R51wWHjdqnYCRPiR8VTQsmHoUJYxdj3sYJIDokgf PkURj8mDK9+TbOc93VXVQSupRTitmv7j9ZBWPLRGspBzzsbK7pi9Z/z3MJthBbYIBveV GjzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=cKNE4Ll3LbqQqi/vsSSnD8gv0zzuQpoyh0gLWN6xhD0=; b=Zuz7O5ZfO1uQhC/U2TZRTC2Da4rH4/f5PdIw8OCE6k9k5SBZPycDrYzQXvKaNqPk8f nGx7Z865F5TIHcObAOfjYebOZvNm295nKrKun1v8jK0K+iSpyRj6r3D0cie9ba/freko DRELmEG3u4ypntv0a61Q2Thbs03FUHPEIhH6gmDcYYpCeA3MiNRkEISwY8+PENdDinb5 S7rhBof32o49rQc1W5f4yQqDy1ODdCMQWHwuA7NSHmEst1M3eTuWOJ5yUCyMz6O50n2s Y88TjlmttCwqdA5zo/XAmieyo7UFYQ+w4wxwfezs5Qjv0QCmPzbI0n2cN25aA2i0Lf8w OxMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=eoOVXWFo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c22si5322518edj.34.2020.12.17.13.27.18; Thu, 17 Dec 2020 13:27:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=eoOVXWFo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729597AbgLQV0Q (ORCPT + 99 others); Thu, 17 Dec 2020 16:26:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729113AbgLQV0Q (ORCPT ); Thu, 17 Dec 2020 16:26:16 -0500 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31BF5C061794 for ; Thu, 17 Dec 2020 13:25:36 -0800 (PST) Received: by mail-pj1-x1035.google.com with SMTP id z12so128940pjn.1 for ; Thu, 17 Dec 2020 13:25:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=cKNE4Ll3LbqQqi/vsSSnD8gv0zzuQpoyh0gLWN6xhD0=; b=eoOVXWFoeqY4b6J7GsYROACiZ6V+ENVkYs79nY5OlPO/qxefEC6xaFwDcXLpfk9ywG LIpolf5jYqYUOxO8lM8Sx44hI+BewEGql7609u0yxyKqwOOxLBFatd/7KDNq8HBSQB74 uBvMRx1KFhx/4w7a8iebx00wUf35+sLx0HW9xtwaDGfG/znI3emStmIYPrBsQfhca7Jr GJNWfbysMeMmfYi0j1JhcBxf04qonRI3mc9BTMIuAikpdtCDXTVDK9q6L+VUvnWSvwS7 g6j+iF3tjhPomCgzcGXlMtiE+lBATNu5i6AxNxY8hUiqES16nvKPk1NMA+8nb+ZWm1Gy 6WGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=cKNE4Ll3LbqQqi/vsSSnD8gv0zzuQpoyh0gLWN6xhD0=; b=ffroZ+gmhLe69ybI9R3eM7WG1psT3PXHqS0k7LTdKAeqEnve6qop2OJ1c8QLfibIEf 1wul8HxVi+e9SjWalNEnW06IHZXsEV7/CTu2AHvmiF/0ENpdI2mIPFmdITMkAVS7So+M vbJQ7/3UzmJZiX+QotbXNgPm9NvA41pWXHRC6mUS8cK4vzAeVqNEeOA0Hg6VAkExLMe5 EUbKa+v+bKHL54rArckUjvF1PzfieVToMw6I5A9ERk8Zn7XP+xYysEfZ8r5mUfAlX7tl ECYM+ogykTrgnN22WycC6jm2GRoNINES/AFLXqCA/iYhc5r7oXVhLwbJNrhgQGT0C6Sa EzcA== X-Gm-Message-State: AOAM533xAis5KGGaLTsGFgNUr4iJGc0XMKkRdc7Z13n5dAF0bFdfRegh FacEuu9EB+I8YW4YE5NiS8AQmg== X-Received: by 2002:a17:902:8498:b029:d8:e2a0:e4e7 with SMTP id c24-20020a1709028498b02900d8e2a0e4e7mr835859plo.49.1608240335511; Thu, 17 Dec 2020 13:25:35 -0800 (PST) Received: from bsegall-glaptop.localhost (c-73-71-82-80.hsd1.ca.comcast.net. [73.71.82.80]) by smtp.gmail.com with ESMTPSA id a141sm6893211pfa.189.2020.12.17.13.25.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Dec 2020 13:25:34 -0800 (PST) From: Benjamin Segall To: Huaixin Chang Cc: linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com, juri.lelli@redhat.com, mgorman@suse.de, mingo@redhat.com, pauld@redhead.com, peterz@infradead.org, pjt@google.com, rostedt@goodmis.org, vincent.guittot@linaro.org, khlebnikov@yandex-team.ru, xiyou.wangcong@gmail.com, shanpeic@linux.alibaba.com Subject: Re: [PATCH 0/4] sched/fair: Burstable CFS bandwidth controller References: <20201217074620.58338-1-changhuaixin@linux.alibaba.com> Date: Thu, 17 Dec 2020 13:25:31 -0800 In-Reply-To: <20201217074620.58338-1-changhuaixin@linux.alibaba.com> (Huaixin Chang's message of "Thu, 17 Dec 2020 15:46:16 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The code for this looks fine, and the feature is something people do seem to ask for occasionally. I agree with peterz that using this generally means you lose any guarantees (which are already imperfect given CFS), but I suspect that cfsb is being used in overload anyways. The docs could use a grammar/wording pass maybe, but that's easy enough.