Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201120092057.2144-1-thunder.leizhen@huawei.com> <7ccddd02-e2e6-ec48-43b8-10700285e61c@huawei.com>
In-Reply-To: <7ccddd02-e2e6-ec48-43b8-10700285e61c@huawei.com>
From:   Dan Williams <dan.j.williams@intel.com>
Date:   Thu, 17 Dec 2020 13:49:11 -0800
Message-ID: <CAPcyv4hLoqYpLxQhPhGA2XxJPOc6VkonjrHSbyEQa2Y=voF8hg@mail.gmail.com>
Subject: Re: [PATCH 1/1] device-dax: delete a redundancy check in dev_dax_validate_align()
To:     "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
Cc:     Vishal Verma <vishal.l.verma@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        linux-nvdimm <linux-nvdimm@lists.01.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Nov 20, 2020 at 1:27 AM Leizhen (ThunderTown)
<thunder.leizhen@huawei.com> wrote:
>
>
>
> On 2020/11/20 17:20, Zhen Lei wrote:
> > After we have done the alignment check for the length of each range, the
> > alignment check for dev_dax_size(dev_dax) is no longer needed, because it
> > get the sum of the length of each range.
>
> For example:
> x/M + y/M = (x + y)/M
> If x/M is a integer and y/M is also a integer, then (x + y)/M must be a integer.
>

True... I was going to say that the different error messages might be
useful, but those are debug statements anyways, so I'll apply this.