Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1661486pxu; Thu, 17 Dec 2020 15:46:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJxIzAI/flY710nZdYtSpdzwq0KSfRvupHTcgCxsxf70Sa7uRafLwrnAGKOvlwybKsEjk/9v X-Received: by 2002:a50:a6c2:: with SMTP id f2mr1821890edc.7.1608248818524; Thu, 17 Dec 2020 15:46:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608248818; cv=none; d=google.com; s=arc-20160816; b=bPVdIfkwlV+kByhaLVQNfiL92k5xDhrfx8HKpPfEJR+S879zFQdKxzQCIb8L+SSvQ+ AqBcB+E/PlDPIPtKeNUFqXA+LkG1pEVccu15GP5WD5FS4FszUAx1FOaPE+ajs3MjG8n/ ODZkj3oRAs4WnQi7bEn+0w3tXNhYSVdDfhkscl+UU/8i7hSr1heQH5Ent9WzV/O0BR1G SQ/s7ymRUQJLu1PT7X7m/kz+nG4Z5Hdxb73+Qba2XXeN2ZZQrbdDWTdFP/RJLJdvjv8d ZiwwHxhSPYAIQXb6Quuu4ACb28KecCJJwyvTLL5J91M8I033Ad9Uk0qIHOuFWEymbxIH jtGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:date:message-id:from:references:to:subject; bh=TNkORHrJZy/W9LE0czDj5AkqzKWxEDdVM0Xn3KgdoZA=; b=yB+3LcSE3ZDM4EUaMzNv7ydo3si215xLFfvNaKqc5G/Rtt8sRg0YZ9lGJF9Dt2SsvN WZZ4KHMNYc5zBOaZ4dbPvuisIT6LVbl/nEjIYbCPW+YEBNmzyiim8dSvdPCiuHYLE5/l RJJG/fBtyXJO0GXskeLBX6u6wx6+PikX2BddhkCm9IrJCjhziIvYiitK0bBaKo5gAWgj yK66ERN8nhk86DcLrOmc1bMwYUxbPLWeE8GJvocwYmYttL3nY+14v6HLNlc8KtWhzww4 UM38OwD0eAWATBVpp+VFO6AraYtYzjVciO4d5Vyh1QGlt0Nwpxz7Jn5hPxy35swESHJE Rqmw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b7si3370783ejq.611.2020.12.17.15.46.28; Thu, 17 Dec 2020 15:46:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729402AbgLQX2Q (ORCPT + 99 others); Thu, 17 Dec 2020 18:28:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726721AbgLQX2P (ORCPT ); Thu, 17 Dec 2020 18:28:15 -0500 Received: from yawp.biot.com (yawp.biot.com [IPv6:2a01:4f8:10a:8e::fce2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D468C061794 for ; Thu, 17 Dec 2020 15:27:35 -0800 (PST) Received: from debian-spamd by yawp.biot.com with sa-checked (Exim 4.93) (envelope-from ) id 1kq2gG-008REz-LP for linux-kernel@vger.kernel.org; Fri, 18 Dec 2020 00:27:33 +0100 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on yawp X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,RDNS_NONE, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.4 Received: from [2a02:578:460c:1:ae1f:6bff:fed1:9ca8] by yawp.biot.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1kq2gG-008REv-Ge; Fri, 18 Dec 2020 00:27:32 +0100 Subject: Re: [PATCH] Add support for Realtek RTL838x/RTL839x switch SoCs To: Oleksij Rempel , tsbogend@alpha.franken.de, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org References: <20201215183557.646034-1-bert@biot.com> From: Bert Vermeulen Message-ID: Date: Fri, 18 Dec 2020 00:27:32 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/15/20 11:11 PM, Oleksij Rempel wrote: > Hello Bert, > > thank you for your work. Here are some comments.. Thanks for reviewing. I will send in a V2 with your comments all handled. > I assume, after applying all needed changes, there will be no files within > arch/mips/include/asm/mach-realtek :) I wish! Unfortunately I need somewhere to put the early printk init call, and the SoC family ID checks -- as they are heavily used in various drivers. -- Bert Vermeulen bert@biot.com