Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201217020311.491799-1-yuxiangyang4@huawei.com> <20201217022306.GB15600@casper.infradead.org>
In-Reply-To: <20201217022306.GB15600@casper.infradead.org>
From:   Souptick Joarder <jrdr.linux@gmail.com>
Date:   Fri, 18 Dec 2020 09:39:30 +0530
Message-ID: <CAFqt6zYeDstXBHP+DCyBdmL4vDFBGekv7jrknU5c175sKVax4w@mail.gmail.com>
Subject: Re: [PATCH] mm/filemap: Fix warning: no previous prototype
To:     Matthew Wilcox <willy@infradead.org>
Cc:     Xiangyang Yu <yuxiangyang4@huawei.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux-MM <linux-mm@kvack.org>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Dec 17, 2020 at 7:53 AM Matthew Wilcox <willy@infradead.org> wrote:
>
> On Thu, Dec 17, 2020 at 10:03:11AM +0800, Xiangyang Yu wrote:
> > Fixed the warning when building with warnings enabled (W=1),
> > This function is only used in filemap.c, so mark this function
> > with 'static'.
>
> Good grief, no.  Look at the git history before proposing a patch.

revert "mm/filemap: add static for function __add_to_page_cache_locked"
Revert commit 3351b16af494 ("mm/filemap: add static for function
__add_to_page_cache_locked") due to incompatibility with
ALLOW_ERROR_INJECTION which result in build errors.

>