Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] Add support for Realtek RTL838x/RTL839x switch SoCs
To:     Bert Vermeulen <bert@biot.com>, tsbogend@alpha.franken.de,
        linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20201215183557.646034-1-bert@biot.com>
 <fbd86bc4-5826-5b2b-5818-3ccd39a090fb@rempel-privat.de>
 <a4d89688-347b-21af-ef29-a28cd480d2d9@biot.com>
From:   Oleksij Rempel <linux@rempel-privat.de>
Message-ID: <2d39c09d-6665-091c-be8f-7793b4e75ab6@rempel-privat.de>
Date:   Fri, 18 Dec 2020 10:57:53 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <a4d89688-347b-21af-ef29-a28cd480d2d9@biot.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Am 18.12.20 um 00:27 schrieb Bert Vermeulen:
> On 12/15/20 11:11 PM, Oleksij Rempel wrote:
>> Hello Bert,
>>
>> thank you for your work. Here are some comments..
>
> Thanks for reviewing. I will send in a V2 with your comments all handled=
.
>
>> I assume, after applying all needed changes, there will be no files
>> within
>> arch/mips/include/asm/mach-realtek :)
>
> I wish! Unfortunately I need somewhere to put the early printk init
> call, and the SoC family ID checks -- as they are heavily used in
> various drivers.

I would recommend you to use generic and exact SoC compatible string in
the devicetree. It will save you and the subsystem maintainers some pain
later. Please do not make drivers depend on the arch/* code.

=2D-
Regards,
Oleksij