Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <c09401d003360cff41c949ccaea8ae9dc7b2c733.camel@perches.com>
Subject: Re: [PATCH] staging: most: video: fixed a parentheses coding style
 issue.
From:   Joe Perches <joe@perches.com>
To:     David Laight <David.Laight@ACULAB.COM>,
        Daniel West <daniel.west.dev@gmail.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc:     "hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
        "mchehab+huawei@kernel.org" <mchehab+huawei@kernel.org>,
        "christian.gromm@microchip.com" <christian.gromm@microchip.com>,
        "masahiroy@kernel.org" <masahiroy@kernel.org>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date:   Fri, 18 Dec 2020 02:08:39 -0800
In-Reply-To: <d5993e314b134e038a1e4eeba32833ce@AcuMS.aculab.com>
References: <20201217234501.351725-1-daniel.west.dev@gmail.com>
         <04c331f6bfce57c253cb86208ebd28f6363e04c0.camel@perches.com>
         <d5993e314b134e038a1e4eeba32833ce@AcuMS.aculab.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 2020-12-18 at 09:49 +0000, David Laight wrote:
> From: Joe Perches
> > Sent: 17 December 2020 23:58
> > 
> > On Thu, 2020-12-17 at 15:45 -0800, Daniel West wrote:
> > > Fixed a coding style issue.
> > 
> > It may pass checkpatch without warning, but it's uncommon kernel coding style.
> 
> checkpatch probably shouldn't complain about lines that end in (
> if they are function definitions.

Opinons vary.

Very few function declaration/definitions in the linux kernel use the
one line per argument style (gnu indent -bfde)

type function(
	type argument1,
	type argument2,
	...
	)
{
	...
}

It probably shouldn't be encouraged.

> > or (> 80 columns)
> > static struct most_video_dev *get_comp_dev(struct most_interface *iface, int channel_idx)
> Or shorten the variable/type names a bit so it all fits.

Always a possibility but probably not a good one here as even
renaming channel_idx to idx doesn't make it < 80 columns