Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1983390pxu; Fri, 18 Dec 2020 02:41:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJydkAj9B/VFx2nj9NehED+EYqnrALINIHWx1p2KZrkpKvwwaDAurYB/k4tfzRyLWbfGoYs2 X-Received: by 2002:aa7:dd05:: with SMTP id i5mr3708882edv.223.1608288076333; Fri, 18 Dec 2020 02:41:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608288076; cv=none; d=google.com; s=arc-20160816; b=SXnrQU/7n4uF49sw+HfEuOjkbkUogcJRrbvAapw0kUAPjajBh9OumSKUE1LWicOsyY OsI70q/pameFkmEahViYBSmuPfLGyMYJ61tzPm+BvC82+lrlrQs8jcmYY3adENzWkw23 IBiE1+GaQ4wM6hs+qmsOg44cJiJXnR8ac/EVGHWcCT9Q7TQstMcIx1gF+ZfHQ9mALm5m yjWsSmGTEmHB8Q/QgPPDwdBTUX/gbnmaoz/axgi/d/CU0M7LEi0t4bSs0tcxC0CHZoow R1Esrz5qtm2AyGcOYISCR0p43yEt2XNr5AjmXvwxF2tZHmj9XlSRW2IL3e06ffbQqcIM S8SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :mime-version:accept-language:in-reply-to:references:message-id:date :thread-index:thread-topic:subject:cc:to:from; bh=Tuf6A2P2GTuuJMZcW9JUFyJ5Si6gHfu8G0UgwHzNp/0=; b=c9zYZ5+UJpdNtWgYT9h8aiOuM04mHOpfCUUXp4pdjaxQLYuLYNNHauRgiq+3JC4q7o bJiMfwnvDSNHs90dmHn1twF63Zkx6sM78K0opoeu72TGnHD7f3bcVRN1zfgtv9hTmYBp iUfB8x8q1mHC/AiWKPM0NzeeJTDKGQHza/OF261kg+fB4k73FlAAWzOF4UOyKgiq+3UL slPg3K67t5WieQ+/X/gWJ5BQMM4WA78LgTweyB+Ci4rZbf0IZXqchZm5uOCl/k7ImQB3 LPyCKs/ndmtFF3RCCY2SgxABvzuwQJvugNhZ8V2wMe1CI9nHBnrDGfp+NLDiAZhSUA9m 9TpA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qh17si2653874ejb.115.2020.12.18.02.40.53; Fri, 18 Dec 2020 02:41:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733172AbgLRKkR convert rfc822-to-8bit (ORCPT + 99 others); Fri, 18 Dec 2020 05:40:17 -0500 Received: from eu-smtp-delivery-151.mimecast.com ([185.58.86.151]:53634 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725875AbgLRKkR (ORCPT ); Fri, 18 Dec 2020 05:40:17 -0500 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-197-PIVC8sKqNfOkRnhW4ZbtOA-1; Fri, 18 Dec 2020 10:38:35 +0000 X-MC-Unique: PIVC8sKqNfOkRnhW4ZbtOA-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Fri, 18 Dec 2020 10:38:35 +0000 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Fri, 18 Dec 2020 10:38:35 +0000 From: David Laight To: 'Joe Perches' , Daniel West , "gregkh@linuxfoundation.org" CC: "hverkuil-cisco@xs4all.nl" , "mchehab+huawei@kernel.org" , "christian.gromm@microchip.com" , "masahiroy@kernel.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] staging: most: video: fixed a parentheses coding style issue. Thread-Topic: [PATCH] staging: most: video: fixed a parentheses coding style issue. Thread-Index: AQHW1NDTd/J3KnGAs0yZSrCCE0TdLqn8mvVQgAAG7ICAAAdwsA== Date: Fri, 18 Dec 2020 10:38:35 +0000 Message-ID: <934cbebcb57a49fd8761cc8b3aaffbfa@AcuMS.aculab.com> References: <20201217234501.351725-1-daniel.west.dev@gmail.com> <04c331f6bfce57c253cb86208ebd28f6363e04c0.camel@perches.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joe Perches > Sent: 18 December 2020 10:09 > On Fri, 2020-12-18 at 09:49 +0000, David Laight wrote: > > From: Joe Perches > > checkpatch probably shouldn't complain about lines that end in ( > > if they are function definitions. > > Opinons vary. > > Very few function declaration/definitions in the linux kernel use the > one line per argument style (gnu indent -bfde) > > type function( > type argument1, > type argument2, > ... > ) > { > ... > } > > It probably shouldn't be encouraged. The only excuse for anything like that is if there are comments for each parameter that are used to generate the interface documentation. Using that style for function calls just wastes vertical space. At least that doesn't happen in the kernel. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)