Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2042034pxu; Fri, 18 Dec 2020 04:14:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJzztuHTiR37zh7QqVQJoeCiAYw2M82tjdM0kDVyb8B2w6rZs1tRBwTP8Wa4h/J9e00VG/rN X-Received: by 2002:a17:907:2506:: with SMTP id y6mr3719953ejl.53.1608293671520; Fri, 18 Dec 2020 04:14:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608293671; cv=none; d=google.com; s=arc-20160816; b=N0gDTr9MALH328ET+/7YzsuA+7taJ+NAXLhLqs14iOfm72tD2q2dIca5N15JHBzbnG k8nbtS99dgltglsb1AQaWxTdzbXG8+/dGsQBj7MZKQTrub+E0FFLeojnTJuRyOCnRN3x HC08K0+AHesWns2qBH6EFvX0GoDXP7AMN6wxRrZThpitB5E6r15BYB1N8J0zGlY6jkz0 ADE7q1aH5rRcEoKIT5akTQA4iRvkTwKW5JbTEmDdE7DaEDwbQW5Hh6hPzbubMe+3SGdk H78A5pJVU+E1aGQVaetAeiRwzYy05UU9xXOebk9JDtXLkoNswuAtz8QNLazmUTjWb+ey bnBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=AA0NVzCgvhtoKwXdH7SuWqhOfSQuQjyKU6kKb97k5FE=; b=awjL/I41eg0eqUh7SesPs/M6GzVIO6ZhvapmQib0uz4zskPiXLoto44C2nThVtNT2Z PrM5JPWrrihTn1k+Rq6tFPO0vT1KbkczJa9NPxQYS2oautuQ6ERQESoUh7cqFSDDmuFg Yj6TFJ5tl08c1JjKcVheh420t5+GxlkBzfzJtCE10dfBILAvgtGvOW1hDbfhTap0tp1d qk5DdFnLeAtBuTAmoIcnqNZcZE56jAICiWiKxMlqOKuowpSz9hpODdttTW9ok3f9LOnc OZZQJyNkc0a32PjAn37+ZzeT8TGK6Mbs/9lmYESPfweC8+VPtLxiSMtNaZddLhAsfvSY /UTQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d14si3912239ejt.356.2020.12.18.04.14.08; Fri, 18 Dec 2020 04:14:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726402AbgLRLpH (ORCPT + 99 others); Fri, 18 Dec 2020 06:45:07 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:9466 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726309AbgLRLpG (ORCPT ); Fri, 18 Dec 2020 06:45:06 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4Cy6T12LY8zhtQJ; Fri, 18 Dec 2020 19:43:49 +0800 (CST) Received: from use12-sp2.huawei.com (10.67.189.174) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.498.0; Fri, 18 Dec 2020 19:44:12 +0800 From: Xiaoming Ni To: , , , , , , , CC: , Subject: [PATCH 2/4] hung_task: Replace "did_panic" with is_be_panic() Date: Fri, 18 Dec 2020 19:44:04 +0800 Message-ID: <20201218114406.61906-3-nixiaoming@huawei.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201218114406.61906-1-nixiaoming@huawei.com> References: <20201218114406.61906-1-nixiaoming@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.67.189.174] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Replace the global variable "did_panic" with is_be_panic() Signed-off-by: Xiaoming Ni --- kernel/hung_task.c | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/kernel/hung_task.c b/kernel/hung_task.c index bb2e3e15c84c..3374b993da4c 100644 --- a/kernel/hung_task.c +++ b/kernel/hung_task.c @@ -50,7 +50,6 @@ unsigned long __read_mostly sysctl_hung_task_check_interval_secs; int __read_mostly sysctl_hung_task_warnings = 10; -static int __read_mostly did_panic; static bool hung_task_show_lock; static bool hung_task_call_panic; static bool hung_task_show_all_bt; @@ -72,18 +71,6 @@ unsigned int __read_mostly sysctl_hung_task_all_cpu_backtrace; unsigned int __read_mostly sysctl_hung_task_panic = CONFIG_BOOTPARAM_HUNG_TASK_PANIC_VALUE; -static int -hung_task_panic(struct notifier_block *this, unsigned long event, void *ptr) -{ - did_panic = 1; - - return NOTIFY_DONE; -} - -static struct notifier_block panic_block = { - .notifier_call = hung_task_panic, -}; - static void check_hung_task(struct task_struct *t, unsigned long timeout) { unsigned long switch_count = t->nvcsw + t->nivcsw; @@ -223,7 +210,7 @@ static void check_hung_uninterruptible_tasks(unsigned long timeout) * If the system crashed already then all bets are off, * do not report extra hung tasks: */ - if (test_taint(TAINT_DIE) || did_panic) + if (test_taint(TAINT_DIE) || unlikely(is_being_panic())) return; hung_task_show_lock = false; @@ -347,8 +334,6 @@ static int watchdog(void *dummy) static int __init hung_task_init(void) { - atomic_notifier_chain_register(&panic_notifier_list, &panic_block); - /* Disable hung task detector on suspend */ pm_notifier(hungtask_pm_notify, 0); -- 2.27.0